mirror of
https://github.com/MinecraftForge/MinecraftForge.git
synced 2026-11-20 04:09:51 +00:00
Typos
1 parent
d65a15d26c
commit
3c75cc0784
1 file changed
+3
-3
@@ -103,10 +103,10 @@ import net.minecraftforge.otherimports
|
||||
if (isCondition) MinecraftForge.EVENT_BUS.post(new net.minecraftforge.event.GenericEvent());
|
||||
<snip>
|
||||
```
|
||||
Sidenote: As FML/Forge is trying to move away from imports try to use `net.minecraftforge.common.MinecraftForge` even when an existing import is already there.
|
||||
Sidenote: The previous example can be improved further. As FML/Forge is trying to move away from imports try to use `net.minecraftforge.common.MinecraftForge` even when an existing import is already there.
|
||||
An even better way is to add a function `net.minecraftforge.event.EventFactory` or `net.minecraftforge.common.ForgeHooks` and use the full qualification function names.
|
||||
|
||||
#### Before `gradle genPatches` & Committing
|
||||
Before committing, check if your IDE hasn't put in extra spaces/line breaks in the import section of you java-file.
|
||||
Eclipse tend to reorganize the imports to improve readability and will cause extra spaces/line breaks to appear in the `.java.patch`-files. Review your patches (`ClassName.java.patch`) and the diff-states of your uncommitted changes on these patches for extra `++`'s or `+ +`'s. This means an extra space/line break has been added
|
||||
Keep in mind that the original `.java.patch`-file never add extra spaces/break lines in between imports. .
|
||||
Eclipse tend to reorganize the imports to improve readability and will cause extra spaces/line breaks to appear in the `.java.patch`-files. Review your patches (`ClassName.java.patch`) and the diff-states of your uncommitted changes on these patches for extra `++`'s or `+ +`'s. This means an extra space/line break has been added.
|
||||
Keep in mind that the original `.java.patch`-file never add extra spaces/break lines in between imports.
|
||||
Reference in new issue
Block a user