diff --git a/If-you-want-to-contribute-to-Forge.md b/If-you-want-to-contribute-to-Forge.md index 2fc32ae..22a9814 100644 --- a/If-you-want-to-contribute-to-Forge.md +++ b/If-you-want-to-contribute-to-Forge.md @@ -103,10 +103,10 @@ import net.minecraftforge.otherimports if (isCondition) MinecraftForge.EVENT_BUS.post(new net.minecraftforge.event.GenericEvent()); ``` -Sidenote: As FML/Forge is trying to move away from imports try to use `net.minecraftforge.common.MinecraftForge` even when an existing import is already there. +Sidenote: The previous example can be improved further. As FML/Forge is trying to move away from imports try to use `net.minecraftforge.common.MinecraftForge` even when an existing import is already there. An even better way is to add a function `net.minecraftforge.event.EventFactory` or `net.minecraftforge.common.ForgeHooks` and use the full qualification function names. #### Before `gradle genPatches` & Committing Before committing, check if your IDE hasn't put in extra spaces/line breaks in the import section of you java-file. -Eclipse tend to reorganize the imports to improve readability and will cause extra spaces/line breaks to appear in the `.java.patch`-files. Review your patches (`ClassName.java.patch`) and the diff-states of your uncommitted changes on these patches for extra `++`'s or `+ +`'s. This means an extra space/line break has been added -Keep in mind that the original `.java.patch`-file never add extra spaces/break lines in between imports. . \ No newline at end of file +Eclipse tend to reorganize the imports to improve readability and will cause extra spaces/line breaks to appear in the `.java.patch`-files. Review your patches (`ClassName.java.patch`) and the diff-states of your uncommitted changes on these patches for extra `++`'s or `+ +`'s. This means an extra space/line break has been added. +Keep in mind that the original `.java.patch`-file never add extra spaces/break lines in between imports. \ No newline at end of file