Remove extraneous javadoc

This commit is contained in:
OrderedSet committed 2026-11-21 23:06:27 -08:00
1 parent 308febfed0
commit e069188aab
2 files changed
+9 -34

No files matched your search

@@ -28,11 +28,6 @@ public final class MobOverlayDisplayList {
private long compiledTicks;
private int compilingChunk;
/**
* Compiles after a {@link MobOverlayScan#getModesVersion} change are debounced to one per {@code MIN_COMPILE_TICKS}
* ticks, because the version changes several times per second while the player moves fast, and a compile runs for a
* millisecond or more.
*/
public boolean isCompileDue(int currentModesVersion, MobOverlayStyle currentStyle, long worldTicks) {
final int MIN_COMPILE_TICKS = 5;
if (firstListId == NO_LIST || style != currentStyle) return true;
@@ -53,12 +48,6 @@ public final class MobOverlayDisplayList {
anchorZ = scan.getMinZ();
}
/**
* Start the list of chunk column ({@code chunkX}, {@code chunkZ}). The quad positions in the list are relative to
* block ({@code chunkX * 16}, {@link MobOverlayScan#getMinY}, {@code chunkZ * 16}).
*
* @return false when the chunk column's list is current. {@code beginChunk} doesn't start a list then
*/
public boolean beginChunk(MobOverlayScan scan, int chunkX, int chunkZ) {
final int chunk = scan.findChunk(chunkX, chunkZ);
final int chunkVersion = scan.readChunkVersion(chunkX, chunkZ);
@@ -104,11 +93,13 @@ public final class MobOverlayDisplayList {
}
private void resize(int newChunkSpan) {
delete();
chunkSpan = newChunkSpan;
final int chunkCount = newChunkSpan * newChunkSpan;
delete();
chunkSpan = newChunkSpan;
firstListId = GLAllocation.generateDisplayLists(chunkCount + 1);
parentListId = firstListId + chunkCount;
isCompiled = new boolean[chunkCount];
hasFaces = new boolean[chunkCount];
compiledChunkVersion = new int[chunkCount];
@@ -61,9 +61,9 @@ public final class MobOverlayScan {
private int nextRescanColumn;
private int modesVersion;
private int chunkSpan;
// indexed by `findChunk()`. The version of a chunk column changes when a cell in or beside the chunk column
// changes, and when an edge of the box moves into, out of, within or across the chunk column. A full scan and a
// vertical move change the version of every chunk column
// The version of a chunk column changes when a cell in or beside the chunk column changes, and when an edge of the
// box moves into, out of, within or across the chunk column. A full scan and a vertical move change the version of
// every chunk column
private int[] chunkVersions = new int[0];
private int chunkVersionCount;
private boolean hasModes;
@@ -189,10 +189,6 @@ public final class MobOverlayScan {
return (byte) (cell & SPAWN_MODE_MASK);
}
/**
* Return the height of the overlay above the bottom of the block. The overlay is above the top of a flat block such
* as a carpet.
*/
public static double computeOverlayYOffset(byte cell) {
final double OVERLAY_GAP = 0.02;
return (double) (cell >> COVER_TOP_SHIFT) / COVER_TOP_STEPS + OVERLAY_GAP;
@@ -321,10 +317,6 @@ public final class MobOverlayScan {
return isChanged;
}
/**
* A move changes the connected outlines of the edge cells on the trailing and the leading side of the box.
* {@link MobOverlayFace#isJoined} doesn't outline a cell's side toward the outside of the box.
*/
private void markMovedEdgeChunks(int oldMin, int offset, Axis moveAxis) {
final int lowFrom = Math.min(oldMin, oldMin + offset);
final int lowTo = Math.max(oldMin, oldMin + offset);
@@ -332,10 +324,6 @@ public final class MobOverlayScan {
markStripChunks(lowFrom + span - 1, lowTo + span - 1, moveAxis);
}
/**
* Mark the chunk columns of blocks {@code from} to {@code to} along the move. The marked chunk columns span the box
* across the move.
*/
private void markStripChunks(int from, int to, Axis moveAxis) {
final int acrossMin = switch (moveAxis) {
case X -> minZ;
@@ -427,8 +415,8 @@ public final class MobOverlayScan {
return 0;
}
// vanilla `SpawnerAnimals.canCreatureTypeSpawnAtLocation()` rejects a normal cube in the cell. Test the
// block before the light read
// vanilla `SpawnerAnimals.canCreatureTypeSpawnAtLocation()` rejects a normal cube in the cell (such as the
// inside of a stone block). Test the block before the light read
if (chunk.getBlock(x & 15, y, z & 15).isNormalCube()) return 0;
if (chunk.getSavedLightValue(EnumSkyBlock.Block, x & 15, y, z & 15) >= 8 || !SpawnerAnimals
@@ -454,10 +442,6 @@ public final class MobOverlayScan {
return (byte) (chunk.getSavedLightValue(EnumSkyBlock.Sky, x & 15, y, z & 15) >= 8 ? 1 : 2);
}
/**
* Return the top of the block at height {@code y} in units of 1 / {@link MobOverlayScan#COVER_TOP_STEPS} block.
* Return 0 for a tall block.
*/
private int readCoverTop(int y) {
final double MAX_COVER_TOP = 0.25;
final Block block = chunk.getBlock(x & 15, y, z & 15);