[Memory-opti:runtime allocations] Reduce amount of NBTTagCompound created in TileEntityMetadata#getItemStack (#78 )

Co-authored-by: Alexdoru <[email protected]>
update 2.8.x deps
2026-11-14 17:24:53 +00:00 · 2025-12-01 23:37:12 +01:00 · 2025-10-18 17:32:14 +02:00 · 2025-10-18 17:30:29 +02:00
2 changed files with 9 additions and 7 deletions
@@ -2,9 +2,9 @@

 dependencies {
    api('com.github.GTNewHorizons:ForestryMC:4.10.17:dev')
-    implementation('com.github.GTNewHorizons:GTNHLib:0.7.0:dev')
+    implementation('com.github.GTNewHorizons:GTNHLib:0.6.40:dev')

-    devOnlyNonPublishable('com.github.GTNewHorizons:NotEnoughItems:2.8.0-GTNH:dev')
+    devOnlyNonPublishable('com.github.GTNewHorizons:NotEnoughItems:2.7.91-GTNH:dev')

    compileOnly('com.github.GTNewHorizons:BuildCraft:7.1.44:api')
    compileOnly('net.industrial-craft:industrialcraft-2:2.2.828-experimental:dev')
@@ -76,12 +76,14 @@ public class TileEntityMetadata extends TileEntity {
    }

    public static ItemStack getItemStack(Block block, int damage) {
-        NBTTagCompound tag = new NBTTagCompound();
-        tag.setInteger("meta", damage);
-
        ItemStack item = new ItemStack(block, 1, 0);
-        item.setItemDamage(Math.min(damage, 16387));
-        item.setTagCompound(tag);
+        if (0 <= damage && damage < Short.MAX_VALUE) {
+            item.setItemDamage(damage);
+        } else {
+            NBTTagCompound tag = new NBTTagCompound();
+            tag.setInteger("meta", damage);
+            item.setTagCompound(tag);
+        }
        return item;
    }
Author	SHA1	Message	Date
boubou19andAlexdoru	5135c0c3c9	[Memory-opti:runtime allocations] Reduce amount of NBTTagCompound created in TileEntityMetadata#getItemStack (#78 ) Co-authored-by: Alexdoru <[email protected]>	2025-12-01 23:37:12 +01:00
Martin Robertz	d0a720ea4b	update 2.8.x deps	2025-10-18 17:32:14 +02:00
Glease	24c1264686	fix batched updates does not call window and machine packet listeners (#74 ) (cherry picked from commit `341fea50ba`)	2025-10-18 17:30:29 +02:00