Set render distance for mob inside mod spawner to 16 blocks (#761)

* set render distance for mob inside mod spawner to 16 blocks

* add config in angelica

* add slider in video setting menu

.gitignore

@@ -36,5 +36,3 @@ addon.local.gradle
 addon.local.gradle.kts
 addon.late.local.gradle
 addon.late.local.gradle.kts
-/*.csv
-!gl_functions.csv

README.MD

@@ -8,19 +8,19 @@
 * It's the angel that pulls you out of OptiFine's hell -Roadhog360
 
 ## **Beta Quality - Here there be Dragons** 
-* Shaders sneak preview - Please don't report issues yet, but please do submit fixes
+* Shaders - Beta
    * Complementary & BSL mostly function, but have some bugs
    * Sildurs, Seus, and any other shader probably doesn't work
 
 
 # Required Dependencies
-* [UniMixins](https://github.com/LegacyModdingMC/UniMixins/releases) >= 0.1.14
-* [GTNHLib](https://github.com/GTNewHorizons/GTNHLib/releases) >= 0.4.2
+* [UniMixins](https://github.com/LegacyModdingMC/UniMixins/releases) >= 0.1.19
+* [GTNHLib](https://github.com/GTNewHorizons/GTNHLib/releases) >= 0.5.20
 * NOTE: Some mods are not required, but a specific version is required if present - see: `Permanent Incompatibilities` below.
 
 # Known (temporary) Incompatibilities
 * Forge Relocation - Currently non Thread Safe; safe if not in use
-* ProjectRed Frames - Currently non Thread Safe; safe if not in use'
+* ProjectRed Frames - Currently non Thread Safe; safe if not in use
 
 # Potential Incompatibilities
 * EndlessIDs - Compat commits have been made, might work, might not - not fully tested

dependencies.gradle

@@ -115,8 +115,4 @@ dependencies {
     testImplementation('org.junit.jupiter:junit-jupiter')
     testImplementation("org.mockito:mockito-core:3.+")
     testImplementation("org.lwjgl.lwjgl:lwjgl:2.9.4-nightly-20150209")
-
-    devOnlyNonPublishable("com.github.javaparser:javaparser-symbol-solver-core:3.26.2") {
-        exclude module: "guava"
-    }
 }

src/main/java/GLFunctionParser.java

@@ -1,120 +0,0 @@
-import com.github.javaparser.StaticJavaParser;
-import com.github.javaparser.ast.CompilationUnit;
-import com.github.javaparser.ast.Node;
-import com.github.javaparser.ast.body.ClassOrInterfaceDeclaration;
-import com.github.javaparser.ast.body.MethodDeclaration;
-import com.github.javaparser.ast.body.Parameter;
-import com.github.javaparser.ast.visitor.VoidVisitorWithDefaults;
-
-import java.io.File;
-import java.io.FileNotFoundException;
-import java.io.PrintWriter;
-import java.nio.file.Path;
-import java.nio.file.Paths;
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Map;
-import java.util.Set;
-import java.util.stream.Collectors;
-import java.util.stream.Stream;
-
-/**
- * Used to generate gl_functions.csv. Which contains a mapping of OpenGL functions provided by LWJGL
- * corresponding to the earliest GL version they appear in.
- */
-public class GLFunctionParser {
-    final static String glPath = "util/gl"; // Path to LWJGL OpenGL bindings source code
-
-    public static void main(String[] args) throws FileNotFoundException {
-        HashMap<String, Set<String>> byFunction = new HashMap<>();
-        File dir = new File(glPath);
-        for (File file : dir.listFiles()) {
-            final String filename = file.getName();
-            if (filename.endsWith(".java") && filename.startsWith("GL") && Character.isDigit(filename.charAt(2))) {
-                Path p = Paths.get(filename);
-
-                String parsedFile = removeFileExtension(p.getFileName().toString());
-
-                CompilationUnit cu = StaticJavaParser.parse(file);
-                cu.accept(new VoidVisitorWithDefaults<>() {
-
-                    @Override
-                    public void defaultAction(Node n, Object arg) {
-                        for( Node child : n.getChildNodes()) {
-                            if(child instanceof ClassOrInterfaceDeclaration cd) {
-                                for (MethodDeclaration md : cd.getMethods()) {
-                                    String methodName = md.getNameAsString() + "(";
-                                    for (Parameter p : md.getParameters()) {
-                                        methodName = methodName + p.getTypeAsString();
-                                    }
-                                    methodName = methodName + ")";
-                                    if(methodName.startsWith("n")) continue;
-
-                                    Set<String> functionSet = byFunction.computeIfAbsent(methodName, k -> new HashSet<>());
-                                    functionSet.add(parsedFile);
-                                }
-                            }
-                        }
-                    }
-                }, null);
-
-            }
-        }
-
-        Map<String, String> functionVersionMap = new HashMap<>();
-
-        for(String function : byFunction.keySet()) {
-
-            Set<String> versionsForFunction = byFunction.get(function);
-            int lowestInt = 46;
-            String lowestString = "GL46";
-            for(String version : versionsForFunction) {
-                int i = Integer.parseInt(version.substring(2, 4));
-                if (i < lowestInt) {
-                    lowestInt = i;
-                    lowestString = version;
-                }
-            }
-            functionVersionMap.put(function, lowestString);
-        }
-
-        List<String[]> outputLines = new ArrayList<>();
-
-        for (Map.Entry<String, String> entry : functionVersionMap.entrySet()) {
-            outputLines.add(new String[] {entry.getKey(), entry.getValue()});
-        }
-
-        File output = new File("output.csv");
-        try (PrintWriter writer = new PrintWriter(output)) {
-            outputLines.stream().map(GLSMFunctionComparison::convertToCSV).forEach(writer::println);
-        }
-    }
-
-    public static String convertToCSV(String[] data) {
-        return Stream.of(data).map(GLSMFunctionComparison::escapeSpecialCharacters).collect(Collectors.joining(","));
-    }
-
-    public static String escapeSpecialCharacters(String data) {
-        if (data == null) {
-            throw new IllegalArgumentException("Input data cannot be null");
-        }
-        String escapedData = data.replaceAll("\\R", " ");
-        if (data.contains(",") || data.contains("\"") || data.contains("'")) {
-            data = data.replace("\"", "\"\"");
-            escapedData = "\"" + data + "\"";
-        }
-        return escapedData;
-    }
-
-    public static String removeFileExtension(String filename) {
-        if (filename == null || filename.isEmpty()) {
-            return filename;
-        }
-
-        String extPattern = "(?<!^)[.]" + "[^.]*$";
-        return filename.replaceAll(extPattern, "");
-    }
-
-}

src/main/java/GLSMFunctionComparison.java

@@ -1,135 +0,0 @@
-import com.github.javaparser.ParserConfiguration;
-import com.github.javaparser.StaticJavaParser;
-import com.github.javaparser.ast.CompilationUnit;
-import com.github.javaparser.ast.Node;
-import com.github.javaparser.ast.body.ClassOrInterfaceDeclaration;
-import com.github.javaparser.ast.body.MethodDeclaration;
-import com.github.javaparser.ast.body.Parameter;
-import com.github.javaparser.ast.visitor.VoidVisitorWithDefaults;
-
-import java.io.BufferedReader;
-import java.io.File;
-import java.io.FileNotFoundException;
-import java.io.FileReader;
-import java.io.IOException;
-import java.io.PrintWriter;
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Map;
-import java.util.Set;
-import java.util.stream.Collectors;
-import java.util.stream.Stream;
-
-/**
- * Used to compare OpenGL functions from gl_functions.csv to current GLStateManager
- * source code to determine what functions have an implementation in GLSM, and what ones don't.
- * Only considers functions which appear in GL 2.1 and lower
- */
-public class GLSMFunctionComparison {
-
-    /**
-     * If set to true, then the outputted CSV will show functions which do have an implementation in GLSM
-     */
-    final static boolean INCLUDE_TRUE = false;
-
-    final static String glFunctionsCsvPath = "gl_functions.csv";
-    final static String glsmPath = "src/main/java/com/gtnewhorizons/angelica/glsm/GLStateManager.java";
-
-    public static Map<String, String> parseGLFunctions() {
-        Map<String, String> map = new HashMap<>();
-
-        try (BufferedReader br = new BufferedReader(new FileReader(glFunctionsCsvPath))) {
-            String line;
-            while ((line = br.readLine()) != null) {
-                String[] values = line.split(",");
-                if (values.length == 2) {
-                    String key = values[0].trim();
-                    String value = values[1].trim();
-                    int versionInt = Integer.parseInt(value.substring(2, 4));
-                    if (versionInt < 30) map.put(key, value);
-                }
-            }
-        } catch (IOException e) {
-            e.printStackTrace();
-        }
-        return map;
-    }
-
-    public static void main(String[] args) throws FileNotFoundException {
-        //GLSM will fail to parse without increasing language level
-        StaticJavaParser.getParserConfiguration().setLanguageLevel(ParserConfiguration.LanguageLevel.JAVA_17);
-
-        Map<String, String> functionMap = parseGLFunctions();
-        Set<String> glsmFunctions = new HashSet<>();
-
-        File glsmFile = new File(glsmPath);
-        CompilationUnit cu = StaticJavaParser.parse(glsmFile);
-        cu.accept(new VoidVisitorWithDefaults<>() {
-
-            @Override
-            public void defaultAction(Node n, Object arg) {
-                for (Node child : n.getChildNodes()) {
-                    if (child instanceof ClassOrInterfaceDeclaration cd) {
-                        for (MethodDeclaration md : cd.getMethods()) {
-                            String methodName = md.getNameAsString() + "(";
-                            for (Parameter p : md.getParameters()) {
-                                methodName = methodName + p.getTypeAsString();
-                            }
-                            methodName = methodName + ")";
-                            glsmFunctions.add(methodName);
-                        }
-                    }
-                }
-            }
-        }, null);
-
-        Map<String, String> functionGLSMMap = new HashMap<>();
-
-        for(String function : functionMap.keySet()) {
-            if (!glsmFunctions.contains(function)) {
-                functionGLSMMap.put(function, "false");
-            } else if (INCLUDE_TRUE) {
-                functionGLSMMap.put(function, "true");
-            }
-        }
-
-        List<String[]> outputLines = new ArrayList<>();
-
-        for (Map.Entry<String, String> entry : functionGLSMMap.entrySet()) {
-            outputLines.add(new String[] {entry.getKey(), functionMap.get(entry.getKey()), entry.getValue()});
-        }
-
-        File output = new File("glsm_function_comparison.csv");
-        try (PrintWriter writer = new PrintWriter(output)) {
-            outputLines.stream().map(GLSMFunctionComparison::convertToCSV).forEach(writer::println);
-        }
-    }
-
-    public static String convertToCSV(String[] data) {
-        return Stream.of(data).map(GLSMFunctionComparison::escapeSpecialCharacters).collect(Collectors.joining(","));
-    }
-
-    public static String escapeSpecialCharacters(String data) {
-        if (data == null) {
-            throw new IllegalArgumentException("Input data cannot be null");
-        }
-        String escapedData = data.replaceAll("\\R", " ");
-        if (data.contains(",") || data.contains("\"") || data.contains("'")) {
-            data = data.replace("\"", "\"\"");
-            escapedData = "\"" + data + "\"";
-        }
-        return escapedData;
-    }
-
-    public static String removeFileExtension(String filename) {
-        if (filename == null || filename.isEmpty()) {
-            return filename;
-        }
-
-        String extPattern = "(?<!^)[.]" + "[^.]*$";
-        return filename.replaceAll(extPattern, "");
-    }
-
-}

src/main/java/com/gtnewhorizons/angelica/config/AngelicaConfig.java

@@ -148,4 +148,9 @@ public class AngelicaConfig {
     @Config.RangeInt(min = 64, max = 1024)
     public static int itemRendererDisplayListCacheSize;
 
+    @Config.Comment("Render distance for the spinning mob inside mod spawners")
+    @Config.DefaultDouble(16D)
+    @Config.RangeDouble(min = 16D, max = 64D)
+    public static double mobSpawnerRenderDistance;
+
 }

src/main/java/com/gtnewhorizons/angelica/glsm/GLStateManager.java

@@ -69,6 +69,7 @@ import java.nio.ByteBuffer;
 import java.nio.DoubleBuffer;
 import java.nio.FloatBuffer;
 import java.nio.IntBuffer;
+import java.nio.ShortBuffer;
 import java.util.AbstractMap;
 import java.util.Map;
 import java.util.Set;
@@ -960,32 +961,52 @@ public class GLStateManager {
         glTexParameteri(GL11.GL_TEXTURE_2D, GL11.GL_TEXTURE_MAG_FILTER, j);
     }
 
-    public static void glDrawArrays(int mode, int first, int count) {
-        // Iris -- TODO: This doesn't seem to work and is related to matchPass()
-        if(AngelicaConfig.enableIris) {
-            Iris.getPipelineManager().getPipeline().ifPresent(WorldRenderingPipeline::syncProgram);
-        }
-        GL11.glDrawArrays(mode, first, count);
-    }
-
-    public static void glDrawBuffer(int mode) {
-        GL11.glDrawBuffer(mode);
-    }
-
-    public static void glDrawElements(int mode, IntBuffer indices) {
-        if(AngelicaConfig.enableIris) {
-            Iris.getPipelineManager().getPipeline().ifPresent(WorldRenderingPipeline::syncProgram);
-        }
-        GL11.glDrawElements(mode, indices);
-    }
-
-    public static void glBegin(int mode) {
+    public static void trySyncProgram() {
         if (AngelicaConfig.enableIris) {
             Iris.getPipelineManager().getPipeline().ifPresent(WorldRenderingPipeline::syncProgram);
         }
+    }
+
+    public static void glBegin(int mode) {
+        trySyncProgram();
         GL11.glBegin(mode);
     }
 
+    public static void glDrawElements(int mode, ByteBuffer indices) {
+        trySyncProgram();
+        GL11.glDrawElements(mode, indices);
+    }
+
+    public static void glDrawElements(int mode, IntBuffer indices) {
+        trySyncProgram();
+        GL11.glDrawElements(mode, indices);
+    }
+
+    public static void glDrawElements(int mode, ShortBuffer indices) {
+        trySyncProgram();
+        GL11.glDrawElements(mode, indices);
+    }
+
+    public static void glDrawElements(int mode, int indices_count, int type, long indices_buffer_offset) {
+        trySyncProgram();
+        GL11.glDrawElements(mode, indices_count, type, indices_buffer_offset);
+    }
+
+    public static void glDrawElements(int mode, int count, int type, ByteBuffer indices) {
+        trySyncProgram();
+        GL11.glDrawElements(mode, count, type, indices);
+    }
+
+    public static void glDrawBuffer(int mode) {
+        trySyncProgram();
+        GL11.glDrawBuffer(mode);
+    }
+
+    public static void glDrawArrays(int mode, int first, int count) {
+        trySyncProgram();
+        GL11.glDrawArrays(mode, first, count);
+    }
+
     public static void glLogicOp(int opcode) {
         GL11.glLogicOp(opcode);
     }
@@ -1240,6 +1261,7 @@ public class GLStateManager {
         if(list < 0) {
             VBOManager.get(list).render();
         } else {
+            trySyncProgram();
             GL11.glCallList(list);
             if(glListChanges.containsKey(list)) {
                 for(Map.Entry<IStateStack<?>, ISettableState<?>> entry : glListChanges.get(list)) {

src/main/java/com/gtnewhorizons/angelica/mixins/Mixins.java

@@ -137,6 +137,7 @@ public enum Mixins {
             ,"sodium.MixinRenderGlobal"
             ,"sodium.MixinWorldClient"
             ,"sodium.MixinTileEntity"
+            ,"sodium.MixinTileEntityMobSpawner"
             ,"sodium.MixinEffectRenderer"
             ,"sodium.MixinTileEntityRendererDispatcher"
             ,"sodium.MixinLongHashMap"

src/main/java/jss/notfine/proxy/ClientProxy.java

@@ -1,19 +1,23 @@
 package jss.notfine.proxy;
 
-import cpw.mods.fml.common.event.FMLInitializationEvent;
+import cpw.mods.fml.common.FMLCommonHandler;
 import cpw.mods.fml.common.event.FMLPostInitializationEvent;
 import cpw.mods.fml.common.event.FMLPreInitializationEvent;
-import cpw.mods.fml.relauncher.Side;
+import cpw.mods.fml.common.eventhandler.SubscribeEvent;
 import jss.notfine.config.NotFineConfig;
 import jss.notfine.core.Settings;
 import jss.notfine.core.SettingsManager;
 import net.minecraft.client.Minecraft;
-import net.minecraft.client.settings.GameSettings;
+import net.minecraftforge.common.MinecraftForge;
+import net.minecraftforge.event.world.WorldEvent;
 
 public class ClientProxy extends CommonProxy {
 
     @Override
     public void preInit(FMLPreInitializationEvent event) {
+        FMLCommonHandler.instance().bus().register(this);
+        MinecraftForge.EVENT_BUS.register(this);
+
         if(!NotFineConfig.allowAdvancedOpenGL) {
             Minecraft.getMinecraft().gameSettings.advancedOpengl = false;
         }
@@ -29,12 +33,13 @@ public class ClientProxy extends CommonProxy {
         }
     }
 
-    @Override
-    public void init(FMLInitializationEvent event) { }
-
     @Override
     public void postInit(FMLPostInitializationEvent event) {
         SettingsManager.settingsFile.loadSettings();
     }
 
+    @SubscribeEvent
+    public void worldLoad(WorldEvent.Load event) {
+        SettingsManager.graphicsUpdated();
+    }
 }

src/main/java/me/jellysquid/mods/sodium/client/gui/SodiumGameOptionPages.java

@@ -164,6 +164,15 @@ public class SodiumGameOptionPages {
                         .setImpact(OptionImpact.MEDIUM)
                         .build()
                 )
+                .add(
+                    OptionImpl.createBuilder(int.class, angelicaOpts)
+                        .setName(I18n.format("options.angelica.mobSpawnerRenderDistance"))
+                        .setTooltip(I18n.format("options.angelica.mobSpawnerRenderDistance.tooltip"))
+                        .setControl(option -> new SliderControl(option, 16, 64, 1, ControlValueFormatter.number()))
+                        .setBinding((options, value) -> AngelicaConfig.mobSpawnerRenderDistance = value, options -> (int) AngelicaConfig.mobSpawnerRenderDistance)
+                        .setImpact(OptionImpact.MEDIUM)
+                        .build()
+                )
                 .build());
 
         return new OptionPage(I18n.format("stat.generalButton"), ImmutableList.copyOf(groups));
@@ -178,8 +187,10 @@ public class SodiumGameOptionPages {
                         .setTooltip(I18n.format("sodium.options.graphics_quality.tooltip"))
                         .setControl(option -> new CyclingControl<>(option, GraphicsMode.class))
                         .setBinding(
-                                (opts, value) -> { opts.fancyGraphics = value.isFancy();
-                                    SettingsManager.graphicsUpdated(); },
+                                (opts, value) -> {
+                                    opts.fancyGraphics = value.isFancy();
+                                    SettingsManager.graphicsUpdated();
+                                    },
                                 opts -> GraphicsMode.fromBoolean(opts.fancyGraphics))
                         .setImpact(OptionImpact.HIGH)
                         .setFlags(OptionFlag.REQUIRES_RENDERER_RELOAD)

src/main/resources/assets/angelica/lang/en_US.lang

@@ -137,6 +137,8 @@ options.dynamic_lights_shader_force=Dynamic Lights - Forced With Shaders
 options.dynamic_lights_shader_force.tooltip=Enabled - Dynamic Lights are shown even when a shader is active, Disabled - Dynamic Lights are disabled when a shader is active. 
 options.angelica.droppedItemLimit=Dropped Item Render Limit
 options.angelica.droppedItemLimit.tooltip=The maximum number of dropped items that will be rendered. Lower values can improve performance.
+options.angelica.mobSpawnerRenderDistance=Mod spawner render distance
+options.angelica.mobSpawnerRenderDistance.tooltip=Render distance for the spinning mob inside mod spawners
 options.angelica.itemdisplaylistcount=Item Renderer Display List Cache Size
 options.angelica.itemdisplaylistcount.tooltip=The maximum number of display lists to cache in the optimized item renderer. Higher values will increase performance but increase VRAM usage.
 pack.iris.select.title=Select

src/mixin/java/com/gtnewhorizons/angelica/mixins/early/angelica/MixinMinecraft.java

@@ -34,6 +34,8 @@ public class MixinMinecraft {
         at = @At(value = "INVOKE", target = "Lorg/lwjgl/opengl/Display;update()V", shift = At.Shift.AFTER, remap = false)
     )
     private void angelica$trackFrametimes(CallbackInfo ci) {
+        if (AngelicaMod.proxy == null) return;
+
         long time = System.nanoTime();
         AngelicaMod.proxy.putFrametime(time - angelica$lastFrameTime);
         angelica$lastFrameTime = time;

src/mixin/java/com/gtnewhorizons/angelica/mixins/early/sodium/MixinTileEntityMobSpawner.java

@@ -0,0 +1,17 @@
+package com.gtnewhorizons.angelica.mixins.early.sodium;
+
+import com.gtnewhorizons.angelica.config.AngelicaConfig;
+import net.minecraft.tileentity.TileEntity;
+import net.minecraft.tileentity.TileEntityMobSpawner;
+import org.spongepowered.asm.mixin.Mixin;
+
+@Mixin(TileEntityMobSpawner.class)
+public class MixinTileEntityMobSpawner extends TileEntity {
+
+    @Override
+    public double getMaxRenderDistanceSquared() {
+        final double d = AngelicaConfig.mobSpawnerRenderDistance;
+        return d * d;
+    }
+
+}