Give transformers more unique and descriptive names

This commit is contained in:
makamys committed 2023-10-21 03:04:02 +02:00
1 parent a4bddd8dbf
commit ddd608a8f8
5 files changed
+14 -21

No files matched your search

@@ -18,7 +18,7 @@ public class DevCompatCore implements IFMLLoadingPlugin {
@Override
public String[] getASMTransformerClass() {
return new String[] {relativeClassName("asm.ModDiscovererTransformer")};
return new String[] {relativeClassName("asm.ClasspathModDiscoveryFixerTransformer")};
}
private static String relativeClassName(String relName) {
@@ -2,7 +2,6 @@ package io.github.legacymoddingmc.unimixins.devcompat.asm;
import static io.github.legacymoddingmc.unimixins.devcompat.DevCompatCore.LOGGER;
import static org.objectweb.asm.Opcodes.INVOKESTATIC;
import static org.objectweb.asm.Opcodes.INVOKEVIRTUAL;
import net.minecraft.launchwrapper.IClassTransformer;
import org.objectweb.asm.ClassReader;
@@ -18,7 +17,7 @@ import java.util.*;
* <p>Fixes classpath mods not getting loaded in dev env when running via the runClient Gradle task.</p>
*/
public class ModDiscovererTransformer implements IClassTransformer {
public class ClasspathModDiscoveryFixerTransformer implements IClassTransformer {
@Override
public byte[] transform(String name, String transformedName, byte[] basicClass) {
@@ -34,7 +33,7 @@ public class ModDiscovererTransformer implements IClassTransformer {
}
private byte[] doTransformModDiscoverer(byte[] bytes) {
LOGGER.info("ModDiscovererTransformer: Transforming ModDiscoverer#findClasspathMods to ignore reparseable coremods.");
LOGGER.info("ClasspathModDiscoveryFixerTransformer: Transforming ModDiscoverer#findClasspathMods to ignore reparseable coremods.");
try {
ClassNode classNode = new ClassNode();
@@ -49,7 +48,7 @@ public class ModDiscovererTransformer implements IClassTransformer {
if(i.getOpcode() == INVOKESTATIC) {
MethodInsnNode mi = (MethodInsnNode)i;
if(mi.owner.equals("cpw/mods/fml/relauncher/CoreModManager") && mi.name.equals("getReparseableCoremods") && mi.desc.equals("()Ljava/util/List;")) {
m.instructions.insertBefore(mi, new MethodInsnNode(INVOKESTATIC, "io/github/legacymoddingmc/unimixins/devcompat/asm/ModDiscovererTransformer$Hooks", "redirectGetReparseableCoremods", mi.desc));
m.instructions.insertBefore(mi, new MethodInsnNode(INVOKESTATIC, "io/github/legacymoddingmc/unimixins/devcompat/asm/ClasspathModDiscoveryFixerTransformer$Hooks", "redirectGetReparseableCoremods", mi.desc));
it.remove();
break;
}