From c4f7fa1dba9a044a76ab49d8449bded752c83ec8 Mon Sep 17 00:00:00 2001 From: makamys Date: Sun, 5 Feb 2023 16:58:16 +0100 Subject: [PATCH] Fix some comments --- .../legacymoddingmc/unimixins/compat/CompatCore.java | 2 +- .../unimixins/compat/asm/ASMRemapperTransformer.java | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/module-compat/src/main/java/io/github/legacymoddingmc/unimixins/compat/CompatCore.java b/module-compat/src/main/java/io/github/legacymoddingmc/unimixins/compat/CompatCore.java index 0f7e734..10f66f6 100644 --- a/module-compat/src/main/java/io/github/legacymoddingmc/unimixins/compat/CompatCore.java +++ b/module-compat/src/main/java/io/github/legacymoddingmc/unimixins/compat/CompatCore.java @@ -30,7 +30,7 @@ public class CompatCore implements IFMLLoadingPlugin { } /** LWJGL3ify excludes transformation of its core package, which prevents us from remapping its - * LwjglRedirectTransformer. However, the exception appears to be unnecessary, since its transformers already + * LwjglRedirectTransformer. However, the exclusion appears to be unnecessary, since its transformers already * have checks that prevent ClassCircularityErrors. */ private static void applyLWJGL3ifyCompatibilityHack() { diff --git a/module-compat/src/main/java/io/github/legacymoddingmc/unimixins/compat/asm/ASMRemapperTransformer.java b/module-compat/src/main/java/io/github/legacymoddingmc/unimixins/compat/asm/ASMRemapperTransformer.java index 5469127..7b411ed 100644 --- a/module-compat/src/main/java/io/github/legacymoddingmc/unimixins/compat/asm/ASMRemapperTransformer.java +++ b/module-compat/src/main/java/io/github/legacymoddingmc/unimixins/compat/asm/ASMRemapperTransformer.java @@ -15,10 +15,11 @@ import org.objectweb.asm.tree.MethodNode; import java.util.*; /** - *

Some classes use Mixin internals, so we need to make sure they uses the correct type names, and remap them if they don't.

+ *

Some classes use Mixin internals, so we need to make sure they use the correct type names, and remap them if they don't.

+ *

We do this for every class for maximum compatibility.

*/ -// Ideally this should be done for every mod class, but we do it selectively out of caution. -// TODO Test if doing this for every class would affect performance or cause other issues. + +// TODO Measure the performance impact of this and switch to doing it selectively if it would improve things. public class ASMRemapperTransformer implements IClassTransformer { /** A class will be remapped if it implements one of these interfaces. */