From 10af73058a135df88140f10be3924c26b265baa2 Mon Sep 17 00:00:00 2001 From: LlamaLad7 Date: Fri, 10 Oct 2025 19:40:19 +0100 Subject: [PATCH] Improvement: Only check for final method overrides if `debug.verify` is enabled. The verifier will catch this anyway, this just gives us a better error which blames the particular mixin, but it's very expensive to check so best avoided in the default case. --- .../spongepowered/asm/mixin/transformer/MixinTargetContext.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/spongepowered/asm/mixin/transformer/MixinTargetContext.java b/src/main/java/org/spongepowered/asm/mixin/transformer/MixinTargetContext.java index 08e10223..e41a3e2b 100644 --- a/src/main/java/org/spongepowered/asm/mixin/transformer/MixinTargetContext.java +++ b/src/main/java/org/spongepowered/asm/mixin/transformer/MixinTargetContext.java @@ -544,7 +544,7 @@ public class MixinTargetContext extends ClassContext implements IMixinContext { } } - if (Bytecode.isVirtual(method)) { + if (this.getEnvironment().getOption(Option.DEBUG_VERIFY) && Bytecode.isVirtual(method)) { Method superMethod = this.targetClassInfo.findMethodInHierarchy(method, SearchType.SUPER_CLASSES_ONLY, Traversal.ALL, 0); if (superMethod != null && superMethod.isFinal()) { throw new InvalidMixinException(this.mixin, String.format("%s%s in %s overrides a final method from %s",