From 018ae8bf8b8d2ca1ee6de8dcb55f48a2a94eee7c Mon Sep 17 00:00:00 2001 From: Alexdoru <57050655+Alexdoru@users.noreply.github.com> Date: Thu, 26 Jan 2023 00:00:13 +0100 Subject: [PATCH] quick fix : 'StringBuilder' can be replaced with 'String' --- src/main/java/tconstruct/armor/items/DiamondApple.java | 8 +++----- src/main/java/tconstruct/items/tools/Arrow.java | 8 +------- src/main/java/tconstruct/items/tools/Shortbow.java | 8 +------- src/main/java/tconstruct/library/tools/ToolCore.java | 8 +------- .../tconstruct/world/itemblocks/CraftedSoilItemBlock.java | 5 +---- 5 files changed, 7 insertions(+), 30 deletions(-) diff --git a/src/main/java/tconstruct/armor/items/DiamondApple.java b/src/main/java/tconstruct/armor/items/DiamondApple.java index bfbc1875..a1d128d6 100644 --- a/src/main/java/tconstruct/armor/items/DiamondApple.java +++ b/src/main/java/tconstruct/armor/items/DiamondApple.java @@ -63,12 +63,10 @@ public class DiamondApple extends ItemFood { /* Name override */ @Override public String getUnlocalizedName(ItemStack itemstack) { - return (new StringBuilder()) - .append("item.food.") - .append(itemNames[ + return "item.food." + + itemNames[ (itemstack.getItemDamage() >= itemNames.length || itemstack.getItemDamage() < 0) ? (0) - : (itemstack.getItemDamage())]) - .toString(); + : (itemstack.getItemDamage())]; } } diff --git a/src/main/java/tconstruct/items/tools/Arrow.java b/src/main/java/tconstruct/items/tools/Arrow.java index d2f00a6d..3a63d7dd 100644 --- a/src/main/java/tconstruct/items/tools/Arrow.java +++ b/src/main/java/tconstruct/items/tools/Arrow.java @@ -183,13 +183,7 @@ public class Arrow extends ToolCore { else color = "\u00a76"; } - String energy = new StringBuilder() - .append(color) - .append(tags.getInteger("Energy")) - .append("/") - .append(getMaxEnergyStored(stack)) - .append(" RF") - .toString(); + String energy = color + tags.getInteger("Energy") + "/" + getMaxEnergyStored(stack) + " RF"; list.add(energy); } if (tags.hasKey("InfiTool")) { diff --git a/src/main/java/tconstruct/items/tools/Shortbow.java b/src/main/java/tconstruct/items/tools/Shortbow.java index 5806bb77..813191ad 100644 --- a/src/main/java/tconstruct/items/tools/Shortbow.java +++ b/src/main/java/tconstruct/items/tools/Shortbow.java @@ -110,13 +110,7 @@ public class Shortbow extends BowBase { else color = "\u00a76"; } - String energy = new StringBuilder() - .append(color) - .append(tags.getInteger("Energy")) - .append("/") - .append(getMaxEnergyStored(stack)) - .append(" RF") - .toString(); + String energy = color + tags.getInteger("Energy") + "/" + getMaxEnergyStored(stack) + " RF"; list.add(energy); } if (tags.hasKey("InfiTool")) { diff --git a/src/main/java/tconstruct/library/tools/ToolCore.java b/src/main/java/tconstruct/library/tools/ToolCore.java index c5120f43..dd4438bf 100644 --- a/src/main/java/tconstruct/library/tools/ToolCore.java +++ b/src/main/java/tconstruct/library/tools/ToolCore.java @@ -272,13 +272,7 @@ public abstract class ToolCore extends Item implements IEnergyContainerItem, IEq else color = "\u00a76"; } - String energy = new StringBuilder() - .append(color) - .append(tags.getInteger("Energy")) - .append("/") - .append(getMaxEnergyStored(stack)) - .append(" RF") - .toString(); + String energy = color + tags.getInteger("Energy") + "/" + getMaxEnergyStored(stack) + " RF"; list.add(energy); } if (tags.hasKey("InfiTool")) { diff --git a/src/main/java/tconstruct/world/itemblocks/CraftedSoilItemBlock.java b/src/main/java/tconstruct/world/itemblocks/CraftedSoilItemBlock.java index c223154d..55d92332 100644 --- a/src/main/java/tconstruct/world/itemblocks/CraftedSoilItemBlock.java +++ b/src/main/java/tconstruct/world/itemblocks/CraftedSoilItemBlock.java @@ -23,10 +23,7 @@ public class CraftedSoilItemBlock extends MultiItemBlock { public String getUnlocalizedName(ItemStack itemstack) { int pos = MathHelper.clamp_int(itemstack.getItemDamage(), 0, blockTypes.length - 1); if (pos <= 4) return super.getUnlocalizedName(itemstack); - return (new StringBuilder()) - .append("block.slime.soil.") - .append(blockTypes[pos]) - .toString(); + return "block.slime.soil." + blockTypes[pos]; } @Override