From b93cfb2a768c65d348fc27a6a7ab085f3852b886 Mon Sep 17 00:00:00 2001 From: zach2039 <16394465+zach2039@users.noreply.github.com> Date: Sun, 31 May 2026 05:03:44 -0500 Subject: [PATCH] Add render distance config and facing check for render (#72) Co-authored-by: sisyphussy <221229741+sisyphussy@users.noreply.github.com> --- .../renderer/TileEntityDrawersRenderer.java | 38 +++++++++++++++---- .../storagedrawers/config/ConfigManager.java | 9 +++++ .../assets/storagedrawers/lang/en_US.lang | 2 + 3 files changed, 41 insertions(+), 8 deletions(-) diff --git a/src/main/java/com/jaquadro/minecraft/storagedrawers/client/renderer/TileEntityDrawersRenderer.java b/src/main/java/com/jaquadro/minecraft/storagedrawers/client/renderer/TileEntityDrawersRenderer.java index 36f5112..ca3eb73 100644 --- a/src/main/java/com/jaquadro/minecraft/storagedrawers/client/renderer/TileEntityDrawersRenderer.java +++ b/src/main/java/com/jaquadro/minecraft/storagedrawers/client/renderer/TileEntityDrawersRenderer.java @@ -4,7 +4,6 @@ import java.util.List; import net.minecraft.block.Block; import net.minecraft.client.Minecraft; -import net.minecraft.client.entity.EntityClientPlayerMP; import net.minecraft.client.gui.FontRenderer; import net.minecraft.client.renderer.OpenGlHelper; import net.minecraft.client.renderer.RenderBlocks; @@ -15,6 +14,7 @@ import net.minecraft.client.renderer.entity.RenderManager; import net.minecraft.client.renderer.texture.TextureManager; import net.minecraft.client.renderer.texture.TextureMap; import net.minecraft.client.renderer.tileentity.TileEntitySpecialRenderer; +import net.minecraft.entity.EntityLivingBase; import net.minecraft.entity.item.EntityItem; import net.minecraft.item.Item; import net.minecraft.item.ItemBlock; @@ -223,10 +223,24 @@ public class TileEntityDrawersRenderer extends TileEntitySpecialRenderer { @Override public void renderTileEntityAt(TileEntity tile, double x, double y, double z, float partialTickTime) { + EntityLivingBase renderViewEntity = Minecraft.getMinecraft().renderViewEntity; + if (renderViewEntity == null) return; + TileEntityDrawers tileDrawers = (TileEntityDrawers) tile; if (tileDrawers == null) return; if (tileDrawers.isShrouded() || tileDrawers.isSealed()) return; + double dx = tile.xCoord + 0.5 - renderViewEntity.posX; + double dy = tile.yCoord + 0.5 - renderViewEntity.posY; + double dz = tile.zCoord + 0.5 - renderViewEntity.posZ; + double distanceSq = dx * dx + dy * dy + dz * dz; + + double range = StorageDrawers.config.getItemRenderDistance(); + if (distanceSq > range * range) return; + + ForgeDirection side = ForgeDirection.getOrientation(tileDrawers.getDirection()); + if (isRenderViewEntityBehindBlock(tile, side)) return; + float depth; Block block = tile.getWorldObj().getBlock(tile.xCoord, tile.yCoord, tile.zCoord); if (block instanceof BlockDrawers) { @@ -240,7 +254,6 @@ public class TileEntityDrawersRenderer extends TileEntitySpecialRenderer { itemRenderer.setRenderManager(RenderManager.instance); - ForgeDirection side = ForgeDirection.getOrientation(tileDrawers.getDirection()); int ambLight = tile.getWorldObj().getLightBrightnessForSkyBlocks( tile.xCoord + side.offsetX, tile.yCoord + side.offsetY, @@ -270,13 +283,8 @@ public class TileEntityDrawersRenderer extends TileEntitySpecialRenderer { } if (StorageDrawers.config.cache.enableQuantifyUpgrades && tileDrawers.isQuantified()) { - EntityClientPlayerMP player = Minecraft.getMinecraft().thePlayer; - double dx = tile.xCoord + 0.5 - player.posX; - double dy = tile.yCoord + 0.5 - player.posY; - double dz = tile.zCoord + 0.5 - player.posZ; - double distance = Math.sqrt(dx * dx + dy * dy + dz * dz); - float alpha = 1.0f; + double distance = Math.sqrt(distanceSq); if (distance > 4.0) { alpha = Math.max(1.0f - (float) ((distance - 4.0) / 6.0), 0.05f); } @@ -584,6 +592,20 @@ public class TileEntityDrawersRenderer extends TileEntitySpecialRenderer { && RenderBlocks.renderItemIn3d(Block.getBlockFromItem(itemStack.getItem()).getRenderType()); } + private boolean isRenderViewEntityBehindBlock(TileEntity tile, ForgeDirection side) { + EntityLivingBase renderViewEntity = Minecraft.getMinecraft().renderViewEntity; + if (renderViewEntity == null) return false; + if (tile == null) return false; + + return switch (side) { + case NORTH -> renderViewEntity.posZ > tile.zCoord; + case SOUTH -> renderViewEntity.posZ < tile.zCoord; + case WEST -> renderViewEntity.posX > tile.xCoord; + case EAST -> renderViewEntity.posX < tile.xCoord; + default -> false; + }; + } + private float getXOffset(int drawerCount, int slot) { switch (drawerCount) { case 1: diff --git a/src/main/java/com/jaquadro/minecraft/storagedrawers/config/ConfigManager.java b/src/main/java/com/jaquadro/minecraft/storagedrawers/config/ConfigManager.java index c62cd23..6291ee8 100644 --- a/src/main/java/com/jaquadro/minecraft/storagedrawers/config/ConfigManager.java +++ b/src/main/java/com/jaquadro/minecraft/storagedrawers/config/ConfigManager.java @@ -69,6 +69,7 @@ public class ConfigManager { public boolean renderStorageUpgrades; public boolean enableDrawerUI; public String itemRenderType; + public double itemRenderDistance; public String breakDrawerDropMode; public boolean creativeTabVanillaWoods; public boolean enableSidedInput; @@ -361,6 +362,10 @@ public class ConfigManager { cache.itemRenderType = config .get(Configuration.CATEGORY_GENERAL, "itemRenderType", "fast", null, new String[] { "fancy", "fast" }) .setLanguageKey(LANG_PREFIX + "prop.itemRenderType").getString(); + cache.itemRenderDistance = config + .get(Configuration.CATEGORY_GENERAL, "itemRenderDistance", 48.0, null, 0.0, 1024.0) + .setLanguageKey(LANG_PREFIX + "prop.itemRenderDistance").getDouble(); + cache.renderStorageUpgrades = config.get(Configuration.CATEGORY_GENERAL, "renderStorageUpgrades", true) .setLanguageKey(LANG_PREFIX + "prop.renderStorageUpgrades").getBoolean(); cache.creativeTabVanillaWoods = config.get(Configuration.CATEGORY_GENERAL, "creativeTabVanillaWoods", true) @@ -540,6 +545,10 @@ public class ConfigManager { return cache.itemRenderType.equals("fancy"); } + public double getItemRenderDistance() { + return cache.itemRenderDistance; + } + public String getPath() { return config.toString(); } diff --git a/src/main/resources/assets/storagedrawers/lang/en_US.lang b/src/main/resources/assets/storagedrawers/lang/en_US.lang index 1ae1245..9d2619e 100644 --- a/src/main/resources/assets/storagedrawers/lang/en_US.lang +++ b/src/main/resources/assets/storagedrawers/lang/en_US.lang @@ -184,6 +184,8 @@ storageDrawers.config.upgrades.level6Mult=Storage Multiplier (VI) storageDrawers.config.prop.itemRenderType=Item Render Type storageDrawers.config.prop.itemRenderType.tooltip=Render items in 3D or flat. +storageDrawers.config.prop.itemRenderDistance=Item Render Distance +storageDrawers.config.prop.itemRenderDistance.tooltip=Render distance for items on drawers. Values over 64 will have no effect due to tile entity render distance limits. storageDrawers.config.prop.enableIndicatorUpgrades=Enable Indicator Upgrades storageDrawers.config.prop.enableStorageUpgrades=Enable Storage Upgrades storageDrawers.config.prop.enableLockUpgrades=Enable Drawer Locking