From 13f832e7c021f2281fc4629de6f67476e6768b22 Mon Sep 17 00:00:00 2001 From: loenaaaa Date: Tue, 13 Jan 2026 06:57:02 +0800 Subject: [PATCH 1/8] some mixin edits --- .../mixins/early/MixinPlayerControllerMP.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java b/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java index 1df40d9..9e0a915 100644 --- a/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java +++ b/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java @@ -12,11 +12,10 @@ import org.spongepowered.asm.mixin.injection.Inject; import org.spongepowered.asm.mixin.injection.callback.CallbackInfo; import com.jaquadro.minecraft.storagedrawers.StorageDrawers; -import com.jaquadro.minecraft.storagedrawers.block.BlockDrawers; import com.jaquadro.minecraft.storagedrawers.block.tile.TileEntityDrawers; import com.jaquadro.minecraft.storagedrawers.network.BlockClickMessage; -@Mixin(PlayerControllerMP.class) +@Mixin(value = PlayerControllerMP.class, priority = 10000) public abstract class MixinPlayerControllerMP { @Shadow @@ -25,11 +24,10 @@ public abstract class MixinPlayerControllerMP { @Inject( method = "onPlayerDamageBlock", at = @At( - value = "INVOKE_ASSIGN", + value = "INVOKE", target = "Lnet/minecraft/block/Block;getPlayerRelativeBlockHardness(Lnet/minecraft/entity/player/EntityPlayer;Lnet/minecraft/world/World;III)F")) private void mixin(int x, int y, int z, int side, CallbackInfo ci) { - if (mc.theWorld.getTileEntity(x, y, z) instanceof TileEntityDrawers ted - && mc.theWorld.getBlock(x, y, z) instanceof BlockDrawers bd) { + if (mc.theWorld.getTileEntity(x, y, z) instanceof TileEntityDrawers ted) { if (ted.getDirection() == side) { final int reach = 5; double eyeX = mc.thePlayer.posX; From 82ba5efed65918972b780ecdc55458abf7aab7e5 Mon Sep 17 00:00:00 2001 From: loenaaaa Date: Tue, 13 Jan 2026 12:49:48 +0800 Subject: [PATCH 2/8] change mixin name --- .../storagedrawers/mixins/early/MixinPlayerControllerMP.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java b/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java index 9e0a915..b7baba4 100644 --- a/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java +++ b/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java @@ -26,7 +26,7 @@ public abstract class MixinPlayerControllerMP { at = @At( value = "INVOKE", target = "Lnet/minecraft/block/Block;getPlayerRelativeBlockHardness(Lnet/minecraft/entity/player/EntityPlayer;Lnet/minecraft/world/World;III)F")) - private void mixin(int x, int y, int z, int side, CallbackInfo ci) { + private void StorageDrawers$checkIfClickingDrawer(int x, int y, int z, int side, CallbackInfo ci) { if (mc.theWorld.getTileEntity(x, y, z) instanceof TileEntityDrawers ted) { if (ted.getDirection() == side) { final int reach = 5; From b72473d99077e2785986c2bbe1a686c426ade15c Mon Sep 17 00:00:00 2001 From: ah-OOG-ah <75745146+ah-OOG-ah@users.noreply.github.com> Date: Mon, 12 Jan 2026 23:54:11 -0500 Subject: [PATCH 3/8] Add missing `@Final` annotation --- .../storagedrawers/mixins/early/MixinPlayerControllerMP.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java b/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java index b7baba4..fdb9200 100644 --- a/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java +++ b/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java @@ -5,6 +5,7 @@ import net.minecraft.client.multiplayer.PlayerControllerMP; import net.minecraft.util.MovingObjectPosition; import net.minecraft.util.Vec3; +import org.spongepowered.asm.mixin.Final; import org.spongepowered.asm.mixin.Mixin; import org.spongepowered.asm.mixin.Shadow; import org.spongepowered.asm.mixin.injection.At; @@ -18,6 +19,7 @@ import com.jaquadro.minecraft.storagedrawers.network.BlockClickMessage; @Mixin(value = PlayerControllerMP.class, priority = 10000) public abstract class MixinPlayerControllerMP { + @Final @Shadow private Minecraft mc; From 395dc2cb570015a2b1126186c910c1feafededd3 Mon Sep 17 00:00:00 2001 From: ah-OOG-ah <75745146+ah-OOG-ah@users.noreply.github.com> Date: Mon, 12 Jan 2026 23:54:19 -0500 Subject: [PATCH 4/8] no pascal case --- .../storagedrawers/mixins/early/MixinPlayerControllerMP.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java b/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java index fdb9200..9109a5d 100644 --- a/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java +++ b/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java @@ -28,7 +28,7 @@ public abstract class MixinPlayerControllerMP { at = @At( value = "INVOKE", target = "Lnet/minecraft/block/Block;getPlayerRelativeBlockHardness(Lnet/minecraft/entity/player/EntityPlayer;Lnet/minecraft/world/World;III)F")) - private void StorageDrawers$checkIfClickingDrawer(int x, int y, int z, int side, CallbackInfo ci) { + private void storageDrawers$checkIfClickingDrawer(int x, int y, int z, int side, CallbackInfo ci) { if (mc.theWorld.getTileEntity(x, y, z) instanceof TileEntityDrawers ted) { if (ted.getDirection() == side) { final int reach = 5; From 9453c8e14db7b6caf1bf3102e11e2d77dcc2c85e Mon Sep 17 00:00:00 2001 From: ah-OOG-ah <75745146+ah-OOG-ah@users.noreply.github.com> Date: Mon, 12 Jan 2026 23:55:34 -0500 Subject: [PATCH 5/8] Un-nest if statements --- .../mixins/early/MixinPlayerControllerMP.java | 36 +++++++++---------- 1 file changed, 16 insertions(+), 20 deletions(-) diff --git a/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java b/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java index 9109a5d..443c9ba 100644 --- a/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java +++ b/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java @@ -29,28 +29,24 @@ public abstract class MixinPlayerControllerMP { value = "INVOKE", target = "Lnet/minecraft/block/Block;getPlayerRelativeBlockHardness(Lnet/minecraft/entity/player/EntityPlayer;Lnet/minecraft/world/World;III)F")) private void storageDrawers$checkIfClickingDrawer(int x, int y, int z, int side, CallbackInfo ci) { - if (mc.theWorld.getTileEntity(x, y, z) instanceof TileEntityDrawers ted) { - if (ted.getDirection() == side) { - final int reach = 5; - double eyeX = mc.thePlayer.posX; - double eyeY = mc.thePlayer.posY + mc.thePlayer.getEyeHeight(); - double eyeZ = mc.thePlayer.posZ; + if (!(mc.theWorld.getTileEntity(x, y, z) instanceof TileEntityDrawers ted)) return; + if (ted.getDirection() != side) return; - Vec3 look = mc.thePlayer.getLookVec(); + final int reach = 5; + double eyeX = mc.thePlayer.posX; + double eyeY = mc.thePlayer.posY + mc.thePlayer.getEyeHeight(); + double eyeZ = mc.thePlayer.posZ; - Vec3 end = Vec3.createVectorHelper( - eyeX + look.xCoord * reach, - eyeY + look.yCoord * reach, - eyeZ + look.zCoord * reach); + Vec3 look = mc.thePlayer.getLookVec(); - MovingObjectPosition mop = mc.theWorld.rayTraceBlocks(Vec3.createVectorHelper(eyeX, eyeY, eyeZ), end); - float hitX = (float) (mop.hitVec.xCoord - mop.blockX); - float hitY = (float) (mop.hitVec.yCoord - mop.blockY); - float hitZ = (float) (mop.hitVec.zCoord - mop.blockZ); - boolean invertShift = StorageDrawers.config.cache.invertShift; - StorageDrawers.network - .sendToServer(new BlockClickMessage(x, y, z, side, hitX, hitY, hitZ, invertShift)); - } - } + Vec3 end = Vec3 + .createVectorHelper(eyeX + look.xCoord * reach, eyeY + look.yCoord * reach, eyeZ + look.zCoord * reach); + + MovingObjectPosition mop = mc.theWorld.rayTraceBlocks(Vec3.createVectorHelper(eyeX, eyeY, eyeZ), end); + float hitX = (float) (mop.hitVec.xCoord - mop.blockX); + float hitY = (float) (mop.hitVec.yCoord - mop.blockY); + float hitZ = (float) (mop.hitVec.zCoord - mop.blockZ); + boolean invertShift = StorageDrawers.config.cache.invertShift; + StorageDrawers.network.sendToServer(new BlockClickMessage(x, y, z, side, hitX, hitY, hitZ, invertShift)); } } From 1db8b6cdd03333fb5bfee5767c14255d8b5ffad4 Mon Sep 17 00:00:00 2001 From: ah-OOG-ah <75745146+ah-OOG-ah@users.noreply.github.com> Date: Mon, 12 Jan 2026 23:57:47 -0500 Subject: [PATCH 6/8] slightly better variable names the lookVec rename was just to get Spotless to shorten that line :trollface: --- .../mixins/early/MixinPlayerControllerMP.java | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java b/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java index 443c9ba..203cea6 100644 --- a/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java +++ b/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/early/MixinPlayerControllerMP.java @@ -28,25 +28,28 @@ public abstract class MixinPlayerControllerMP { at = @At( value = "INVOKE", target = "Lnet/minecraft/block/Block;getPlayerRelativeBlockHardness(Lnet/minecraft/entity/player/EntityPlayer;Lnet/minecraft/world/World;III)F")) - private void storageDrawers$checkIfClickingDrawer(int x, int y, int z, int side, CallbackInfo ci) { - if (!(mc.theWorld.getTileEntity(x, y, z) instanceof TileEntityDrawers ted)) return; - if (ted.getDirection() != side) return; + private void storageDrawers$checkIfClickingDrawer(int x, int y, int z, int clickedSide, CallbackInfo ci) { + final var thisTile = mc.theWorld.getTileEntity(x, y, z); + if (!(thisTile instanceof TileEntityDrawers drawer)) return; + if (drawer.getDirection() != clickedSide) return; final int reach = 5; double eyeX = mc.thePlayer.posX; double eyeY = mc.thePlayer.posY + mc.thePlayer.getEyeHeight(); double eyeZ = mc.thePlayer.posZ; - Vec3 look = mc.thePlayer.getLookVec(); + Vec3 lookVec = mc.thePlayer.getLookVec(); - Vec3 end = Vec3 - .createVectorHelper(eyeX + look.xCoord * reach, eyeY + look.yCoord * reach, eyeZ + look.zCoord * reach); + Vec3 end = Vec3.createVectorHelper( + eyeX + lookVec.xCoord * reach, + eyeY + lookVec.yCoord * reach, + eyeZ + lookVec.zCoord * reach); MovingObjectPosition mop = mc.theWorld.rayTraceBlocks(Vec3.createVectorHelper(eyeX, eyeY, eyeZ), end); float hitX = (float) (mop.hitVec.xCoord - mop.blockX); float hitY = (float) (mop.hitVec.yCoord - mop.blockY); float hitZ = (float) (mop.hitVec.zCoord - mop.blockZ); boolean invertShift = StorageDrawers.config.cache.invertShift; - StorageDrawers.network.sendToServer(new BlockClickMessage(x, y, z, side, hitX, hitY, hitZ, invertShift)); + StorageDrawers.network.sendToServer(new BlockClickMessage(x, y, z, clickedSide, hitX, hitY, hitZ, invertShift)); } } From ff8d9822b02aad97e19805496423424ec00a24e9 Mon Sep 17 00:00:00 2001 From: ah-OOG-ah <75745146+ah-OOG-ah@users.noreply.github.com> Date: Tue, 13 Jan 2026 01:09:17 -0500 Subject: [PATCH 7/8] Fix mixin json names --- .../minecraft/storagedrawers/mixins/EarlyMixinsLoader.java | 2 +- ...oragedrawers.early.json => mixins.StorageDrawers.early.json} | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) rename src/main/resources/{mixins.storagedrawers.early.json => mixins.StorageDrawers.early.json} (78%) diff --git a/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/EarlyMixinsLoader.java b/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/EarlyMixinsLoader.java index 2a11cc3..5bf1ba1 100644 --- a/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/EarlyMixinsLoader.java +++ b/src/main/java/com/jaquadro/minecraft/storagedrawers/mixins/EarlyMixinsLoader.java @@ -40,7 +40,7 @@ public class EarlyMixinsLoader implements IFMLLoadingPlugin, IEarlyMixinLoader { // rename the associated .json file by replacing the "mymodid" with your own mod ID // in the .json file edit the "package" and "refmap" properties to match your mod // also edit the "refmap" property in the "mixins.mymodid.json" file - return "mixins.storagedrawers.early.json"; + return "mixins.StorageDrawers.early.json"; } @Override diff --git a/src/main/resources/mixins.storagedrawers.early.json b/src/main/resources/mixins.StorageDrawers.early.json similarity index 78% rename from src/main/resources/mixins.storagedrawers.early.json rename to src/main/resources/mixins.StorageDrawers.early.json index d16a818..cb123f6 100644 --- a/src/main/resources/mixins.storagedrawers.early.json +++ b/src/main/resources/mixins.StorageDrawers.early.json @@ -2,7 +2,7 @@ "required": true, "minVersion": "0.8.5-GTNH", "package": "com.jaquadro.minecraft.storagedrawers.mixins.early", - "refmap": "mixins.storagedrawers.refmap.json", + "refmap": "mixins.StorageDrawers.refmap.json", "target": "@env(DEFAULT)", "compatibilityLevel": "JAVA_8" } \ No newline at end of file From 6ed65fcb3bce99825e76e157c8c6f6f0d75f499d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?L=C3=A9a=20Gris?= Date: Tue, 13 Jan 2026 16:29:27 +0100 Subject: [PATCH 8/8] Fix(render): Bottom face rotation and UV (#58) --- .../storagedrawers/client/renderer/DrawersRenderer.java | 4 +++- .../minecraft/storagedrawers/util/RenderHelperLL.java | 8 ++++---- .../minecraft/storagedrawers/util/RenderHelperState.java | 2 +- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/main/java/com/jaquadro/minecraft/storagedrawers/client/renderer/DrawersRenderer.java b/src/main/java/com/jaquadro/minecraft/storagedrawers/client/renderer/DrawersRenderer.java index 8772513..58838e9 100644 --- a/src/main/java/com/jaquadro/minecraft/storagedrawers/client/renderer/DrawersRenderer.java +++ b/src/main/java/com/jaquadro/minecraft/storagedrawers/client/renderer/DrawersRenderer.java @@ -75,7 +75,9 @@ public class DrawersRenderer implements ISimpleBlockRenderingHandler { int meta = world.getBlockMetadata(x, y, z); renderHelper.state - .setUVRotation(RenderHelper.YPOS, RenderHelperState.ROTATION_BY_FACE_FACE[RenderHelper.ZNEG][side]); + .setUVRotation(RenderHelper.YPOS, RenderHelperState.ROTATION_BY_FACE_FACE[RenderHelper.YPOS][side]); + renderHelper.state + .setUVRotation(RenderHelper.YNEG, RenderHelperState.ROTATION_BY_FACE_FACE[RenderHelper.YNEG][side]); boxRenderer.setUnit(block.getTrimWidth()); boxRenderer.setColor(ModularBoxRenderer.COLOR_WHITE); diff --git a/src/main/java/com/jaquadro/minecraft/storagedrawers/util/RenderHelperLL.java b/src/main/java/com/jaquadro/minecraft/storagedrawers/util/RenderHelperLL.java index 881349f..137aa60 100644 --- a/src/main/java/com/jaquadro/minecraft/storagedrawers/util/RenderHelperLL.java +++ b/src/main/java/com/jaquadro/minecraft/storagedrawers/util/RenderHelperLL.java @@ -147,17 +147,17 @@ public class RenderHelperLL { private void setFaceYNegUV(IIcon icon, double minX, double minZ, double maxX, double maxZ) { int rotate = state.uvRotate[RenderHelper.YNEG]; if (rotate == RenderHelperState.ROTATE0) - setUV(icon, minX + state.shiftU, maxX + state.shiftU, maxZ + state.shiftV, minZ + state.shiftV); + setUV(icon, maxX + state.shiftU, minX + state.shiftU, maxZ + state.shiftV, minZ + state.shiftV); if (rotate == RenderHelperState.ROTATE90) - setUV(icon, 1 - maxZ + state.shiftU, 1 - minZ + state.shiftU, minX + state.shiftV, maxX + state.shiftV); + setUV(icon, 1 - minZ + state.shiftU, 1 - maxZ + state.shiftU, minX + state.shiftV, maxX + state.shiftV); if (rotate == RenderHelperState.ROTATE180) setUV( icon, - 1 - minX + state.shiftU, 1 - maxX + state.shiftU, + 1 - minX + state.shiftU, 1 - maxZ + state.shiftV, 1 - minZ + state.shiftV); if (rotate == RenderHelperState.ROTATE270) - setUV(icon, maxZ + state.shiftU, minZ + state.shiftU, 1 - minX + state.shiftV, 1 - maxX + state.shiftV); + setUV(icon, minZ + state.shiftU, maxZ + state.shiftU, 1 - minX + state.shiftV, 1 - maxX + state.shiftV); } private void setFaceYPosUV(IIcon icon, double minX, double minZ, double maxX, double maxZ) { diff --git a/src/main/java/com/jaquadro/minecraft/storagedrawers/util/RenderHelperState.java b/src/main/java/com/jaquadro/minecraft/storagedrawers/util/RenderHelperState.java index 162957f..13593c7 100644 --- a/src/main/java/com/jaquadro/minecraft/storagedrawers/util/RenderHelperState.java +++ b/src/main/java/com/jaquadro/minecraft/storagedrawers/util/RenderHelperState.java @@ -7,7 +7,7 @@ public class RenderHelperState { public static final int ROTATE180 = 2; public static final int ROTATE270 = 3; - public static final int[][] ROTATION_BY_FACE_FACE = { { 0, 0, 0, 0, 0, 0 }, { 0, 0, 0, 0, 0, 0 }, + public static final int[][] ROTATION_BY_FACE_FACE = { { 0, 0, 0, 2, 1, 3 }, { 0, 0, 0, 2, 3, 1 }, { 0, 0, 0, 2, 3, 1 }, { 0, 0, 2, 0, 1, 3 }, { 0, 0, 1, 3, 0, 2 }, { 0, 0, 3, 1, 2, 0 }, }; public static final int[][] FACE_BY_FACE_ROTATION = { { 0, 0, 0, 0 }, { 1, 1, 1, 1 }, { 2, 5, 3, 4 },