diff --git a/src/main/java/mcp/mobius/opis/events/PlayerTracker.java b/src/main/java/mcp/mobius/opis/events/PlayerTracker.java index 8e0e6c8..921b503 100644 --- a/src/main/java/mcp/mobius/opis/events/PlayerTracker.java +++ b/src/main/java/mcp/mobius/opis/events/PlayerTracker.java @@ -42,6 +42,9 @@ public enum PlayerTracker{ } public AccessLevel getPlayerAccessLevel(String name){ + + //TODO : This should be made proper. Right now, this is a security risk with mods changing names. + //TODO : Maybe use uuid as a name and check here against the RconServer list of uuids ? if (name.startsWith("RConInboundHandler")) return AccessLevel.PRIVILEGED; diff --git a/src/main/java/mcp/mobius/opis/network/rconserver/RConInboundHandler.java b/src/main/java/mcp/mobius/opis/network/rconserver/RConInboundHandler.java index e7964ad..d8ef69c 100644 --- a/src/main/java/mcp/mobius/opis/network/rconserver/RConInboundHandler.java +++ b/src/main/java/mcp/mobius/opis/network/rconserver/RConInboundHandler.java @@ -9,6 +9,7 @@ import mcp.mobius.opis.events.PlayerTracker; import mcp.mobius.opis.network.PacketBase; import mcp.mobius.opis.network.enums.Message; import mcp.mobius.opis.network.packets.client.PacketReqData; +import net.minecraft.entity.player.EntityPlayerMP; import net.minecraftforge.common.DimensionManager; import net.minecraftforge.common.util.FakePlayer; import net.minecraftforge.common.util.FakePlayerFactory; @@ -28,6 +29,8 @@ class RConInboundHandler extends ChannelInboundHandlerAdapter{ FakePlayer fakePlayer = FakePlayerFactory.get(DimensionManager.getWorld(0), new GameProfile(fakeUUID, ctx.name())); RConServer.instance.fakePlayers.put(fakePlayer, ctx); + PlayerTracker.INSTANCE.playersSwing.add(fakePlayer); + modOpis.log.info(String.format("Connection to rcon detected. FakePlayer %s with uuid %s created.", ctx.name(), fakeUUID)); } diff --git a/src/main/java/mcp/mobius/opis/network/rconserver/RConServer.java b/src/main/java/mcp/mobius/opis/network/rconserver/RConServer.java index 3c3ae3b..95c86c3 100644 --- a/src/main/java/mcp/mobius/opis/network/rconserver/RConServer.java +++ b/src/main/java/mcp/mobius/opis/network/rconserver/RConServer.java @@ -102,9 +102,6 @@ public class RConServer implements Runnable { buf.writeBytes(data); ctx.write(buf); ctx.flush(); - - modOpis.log.info("We should be sending back something here"); - } }