From 8fb945cb87fdae6990569dfd1dd50afe6bc86d80 Mon Sep 17 00:00:00 2001 From: Madsthunder Date: Thu, 29 Dec 2016 21:45:59 -0500 Subject: [PATCH] Updated If you want to contribute to Forge (markdown) --- If-you-want-to-contribute-to-Forge.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/If-you-want-to-contribute-to-Forge.md b/If-you-want-to-contribute-to-Forge.md index d39d644..43ab1bb 100644 --- a/If-you-want-to-contribute-to-Forge.md +++ b/If-you-want-to-contribute-to-Forge.md @@ -109,7 +109,7 @@ import net.minecraftforge.otherimports Sidenote: The previous example can be improved further. As FML/Forge is trying to move away from imports try to use `net.minecraftforge.common.MinecraftForge` even when an existing import is already there. An even better way is to add a function in `net.minecraftforge.event.EventFactory` or `net.minecraftforge.common.ForgeHooks` and use the full qualification function names. -#### Before `gradle genPatches` & Committing +#### Before `gradlew genPatches` & Committing Before committing, check if your IDE hasn't put in extra spaces/line breaks in the import section of your java-file. Eclipse tend to reorganize the imports to improve readability and will cause extra spaces/line breaks to appear in the `.java.patch`-files. Review your patches (`ClassName.java.patch`) and the diff-states of your uncommitted changes on these patches for extra `++`'s or `+ +`'s. This means an extra space/line break has been added. Keep in mind that the original `.java.patch`-file never add extra spaces/break lines in between imports. \ No newline at end of file