From 393e2441d2cfe9530de7903ea7c3a372e0aed420 Mon Sep 17 00:00:00 2001 From: Scribblon Date: Fri, 1 Aug 2014 05:36:42 -0700 Subject: [PATCH] Typos. (You / your) --- If-you-want-to-contribute-to-Forge.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/If-you-want-to-contribute-to-Forge.md b/If-you-want-to-contribute-to-Forge.md index 33e3e12..6755598 100644 --- a/If-you-want-to-contribute-to-Forge.md +++ b/If-you-want-to-contribute-to-Forge.md @@ -104,9 +104,9 @@ import net.minecraftforge.otherimports ``` Sidenote: The previous example can be improved further. As FML/Forge is trying to move away from imports try to use `net.minecraftforge.common.MinecraftForge` even when an existing import is already there. -An even better way is to add a function `net.minecraftforge.event.EventFactory` or `net.minecraftforge.common.ForgeHooks` and use the full qualification function names. +An even better way is to add a function in `net.minecraftforge.event.EventFactory` or `net.minecraftforge.common.ForgeHooks` and use the full qualification function names. #### Before `gradle genPatches` & Committing -Before committing, check if your IDE hasn't put in extra spaces/line breaks in the import section of you java-file. +Before committing, check if your IDE hasn't put in extra spaces/line breaks in the import section of your java-file. Eclipse tend to reorganize the imports to improve readability and will cause extra spaces/line breaks to appear in the `.java.patch`-files. Review your patches (`ClassName.java.patch`) and the diff-states of your uncommitted changes on these patches for extra `++`'s or `+ +`'s. This means an extra space/line break has been added. Keep in mind that the original `.java.patch`-file never add extra spaces/break lines in between imports. \ No newline at end of file