From cd8eccc29c7f5a3d3436c9cb3e60a96fd9b1555c Mon Sep 17 00:00:00 2001 From: Paint_Ninja Date: Thu, 29 Oct 2026 17:49:21 +0000 Subject: [PATCH] Deprecate some rarely used events for removal (#10904) See PR description for details --- .../client/event/GatherAtlasMetadataSectionsEvent.java | 7 ++++++- .../java/net/minecraftforge/common/util/BrainBuilder.java | 1 + .../event/entity/living/LivingMakeBrainEvent.java | 5 +++++ .../event/entity/living/LivingPackSizeEvent.java | 4 ++++ .../event/entity/living/MonsterDisguiseEvent.java | 4 ++-- .../net/minecraftforge/event/level/AlterGroundEvent.java | 5 +++++ .../minecraftforge/event/level/BlockFeatureGrowEvent.java | 5 +++++ 7 files changed, 28 insertions(+), 3 deletions(-) diff --git a/src/main/java/net/minecraftforge/client/event/GatherAtlasMetadataSectionsEvent.java b/src/main/java/net/minecraftforge/client/event/GatherAtlasMetadataSectionsEvent.java index 03bba3ef7e..000a307afd 100644 --- a/src/main/java/net/minecraftforge/client/event/GatherAtlasMetadataSectionsEvent.java +++ b/src/main/java/net/minecraftforge/client/event/GatherAtlasMetadataSectionsEvent.java @@ -13,7 +13,12 @@ import java.util.Set; /** * Fired when an Atlas is being loaded. * This allows you to add custom metadata sections that will be loaded from the sprite's .mcmeta file. + * + * @deprecated This event is scheduled for removal in 26.4 due to a lack of adoption by mods, in order to ease porting. + * Please reach out to the Forge team if you are relying on this and would like to see it remain in Forge. + * We may keep it or add it back in a future version if there is enough demand. */ +@Deprecated(forRemoval = true, since = "26.4") public final class GatherAtlasMetadataSectionsEvent extends MutableEvent { public static final EventBus BUS = EventBus.create(GatherAtlasMetadataSectionsEvent.class); @@ -26,4 +31,4 @@ public final class GatherAtlasMetadataSectionsEvent extends MutableEvent { public void addType(MetadataSectionType definition) { this.types.add(definition); } -} \ No newline at end of file +} diff --git a/src/main/java/net/minecraftforge/common/util/BrainBuilder.java b/src/main/java/net/minecraftforge/common/util/BrainBuilder.java index 096198c3f4..d1ae91b283 100644 --- a/src/main/java/net/minecraftforge/common/util/BrainBuilder.java +++ b/src/main/java/net/minecraftforge/common/util/BrainBuilder.java @@ -42,6 +42,7 @@ import org.jspecify.annotations.Nullable; * * Of course, nothing egregious will happen should a modder choose to use them for their own purposes.
*/ +@Deprecated(forRemoval = true, since = "26.4") public class BrainBuilder { private final Collection> memoryTypes = new HashSet<>(); private final Collection>> sensorTypes = new HashSet<>(); diff --git a/src/main/java/net/minecraftforge/event/entity/living/LivingMakeBrainEvent.java b/src/main/java/net/minecraftforge/event/entity/living/LivingMakeBrainEvent.java index 133c4a7487..93360ed493 100644 --- a/src/main/java/net/minecraftforge/event/entity/living/LivingMakeBrainEvent.java +++ b/src/main/java/net/minecraftforge/event/entity/living/LivingMakeBrainEvent.java @@ -24,7 +24,12 @@ import net.minecraftforge.eventbus.api.event.MutableEvent; * and replace the previously created Brain instance for the entity.
*
* This event is fired via the {@link ForgeHooks#onLivingMakeBrain(LivingEntity, Brain, Dynamic)}.
+ * + * @deprecated This event is scheduled for removal in 26.4 due to a lack of adoption by mods, in order to ease porting. + * Please reach out to the Forge team if you are relying on this and would like to see it remain in Forge. + * We may keep it or add it back in a future version if there is enough demand. **/ +@Deprecated(forRemoval = true, since = "26.4") public final class LivingMakeBrainEvent extends MutableEvent implements LivingEvent { public static final EventBus BUS = EventBus.create(LivingMakeBrainEvent.class); diff --git a/src/main/java/net/minecraftforge/event/entity/living/LivingPackSizeEvent.java b/src/main/java/net/minecraftforge/event/entity/living/LivingPackSizeEvent.java index 38ab54d011..51b7ba2af3 100644 --- a/src/main/java/net/minecraftforge/event/entity/living/LivingPackSizeEvent.java +++ b/src/main/java/net/minecraftforge/event/entity/living/LivingPackSizeEvent.java @@ -12,6 +12,10 @@ import net.minecraftforge.eventbus.api.bus.EventBus; import net.minecraftforge.eventbus.api.event.MutableEvent; import org.jspecify.annotations.NullMarked; +/// @deprecated This event is scheduled for removal in 26.4 due to a lack of adoption by mods, in order to ease porting. +/// Please reach out to the Forge team if you are relying on this and would like to see it remain in Forge. +/// We may keep it or add it back in a future version if there is enough demand. +@Deprecated(forRemoval = true, since = "26.4") @NullMarked public final class LivingPackSizeEvent extends MutableEvent implements LivingEvent, HasResult { public static final EventBus BUS = EventBus.create(LivingPackSizeEvent.class); diff --git a/src/main/java/net/minecraftforge/event/entity/living/MonsterDisguiseEvent.java b/src/main/java/net/minecraftforge/event/entity/living/MonsterDisguiseEvent.java index 442e7d3d51..7ef0c748bb 100644 --- a/src/main/java/net/minecraftforge/event/entity/living/MonsterDisguiseEvent.java +++ b/src/main/java/net/minecraftforge/event/entity/living/MonsterDisguiseEvent.java @@ -7,14 +7,14 @@ package net.minecraftforge.event.entity.living; import net.minecraft.world.entity.monster.Monster; import net.minecraft.world.entity.player.Player; -import net.minecraftforge.common.extensions.IForgeItem; +import net.minecraftforge.common.extensions.IForgeItemStack; import net.minecraftforge.eventbus.api.bus.CancellableEventBus; import net.minecraftforge.eventbus.api.event.RecordEvent; import net.minecraftforge.eventbus.api.event.characteristic.Cancellable; /** * This event is fired on the forge bus before an Monster detects that a player is looking at them. - * It will not be fired if the detection is already prevented by {@link IForgeItem#isEnderMask} + * It will not be fired if the detection is already prevented by {@link IForgeItemStack#isMonsterDisguise(Player, Monster)} *

* This event is {@linkplain Cancellable cancellable}. * If this event is cancelled, the Monster will not target the player. diff --git a/src/main/java/net/minecraftforge/event/level/AlterGroundEvent.java b/src/main/java/net/minecraftforge/event/level/AlterGroundEvent.java index 63ecbd0973..c7f0de554e 100644 --- a/src/main/java/net/minecraftforge/event/level/AlterGroundEvent.java +++ b/src/main/java/net/minecraftforge/event/level/AlterGroundEvent.java @@ -22,7 +22,12 @@ import org.jetbrains.annotations.ApiStatus; * This event is not {@linkplain Cancellable cancellable}. *

* This event is fired only on the {@linkplain net.minecraftforge.fml.LogicalSide#SERVER logical server}. + * + * @deprecated This event is scheduled for removal in 26.4 due to a lack of adoption by mods, in order to ease porting. + * Please reach out to the Forge team if you are relying on this and would like to see it remain in Forge. + * We may keep it or add it back in a future version if there is enough demand. */ +@Deprecated(forRemoval = true, since = "26.4") public final class AlterGroundEvent extends MutableEvent { public static final EventBus BUS = EventBus.create(AlterGroundEvent.class); diff --git a/src/main/java/net/minecraftforge/event/level/BlockFeatureGrowEvent.java b/src/main/java/net/minecraftforge/event/level/BlockFeatureGrowEvent.java index d3dae8e589..47d2c0b6de 100644 --- a/src/main/java/net/minecraftforge/event/level/BlockFeatureGrowEvent.java +++ b/src/main/java/net/minecraftforge/event/level/BlockFeatureGrowEvent.java @@ -27,7 +27,12 @@ import org.jetbrains.annotations.Nullable; * {@linkplain Result#DENY DENY} will prevent the sapling from growing. *

* This event is fired only on the {@linkplain net.minecraftforge.fml.LogicalSide#SERVER logical server}. + * + * @deprecated This event is scheduled for removal in 26.4 due to a lack of adoption by mods, in order to ease porting. + * Please reach out to the Forge team if you are relying on this and would like to see it remain in Forge. + * We may keep it or add it back in a future version if there is enough demand. */ +@Deprecated(forRemoval = true, since = "26.4") public final class BlockFeatureGrowEvent implements LevelEvent, HasResult { public static final EventBus BUS = EventBus.create(BlockFeatureGrowEvent.class);