mirror of
https://github.com/MinecraftForge/MinecraftForge.git
synced 2026-11-21 12:42:26 +00:00
Fix BufferBuilder not expanding under some conditions. (#4538)
This commit is contained in:
1 parent
b1da6cdc8d
commit
c16906f8d8
2 files changed
+94
No files matched your search
@@ -0,0 +1,85 @@
|
||||
package net.minecraftforge.test;
|
||||
|
||||
import net.minecraft.client.renderer.BufferBuilder;
|
||||
import net.minecraft.client.renderer.vertex.DefaultVertexFormats;
|
||||
import net.minecraft.client.renderer.vertex.VertexFormat;
|
||||
import org.junit.Test;
|
||||
|
||||
import java.util.Arrays;
|
||||
|
||||
import static org.junit.Assert.assertTrue;
|
||||
|
||||
public class BufferBuilderExpansionTest
|
||||
{
|
||||
|
||||
public VertexFormat format = DefaultVertexFormats.POSITION;
|
||||
// 4 quads.
|
||||
public int num_quads = 4;
|
||||
public int BUFFER_SIZE = format.getNextOffset() * (num_quads * 4);
|
||||
|
||||
@Test//Test the expansion of the buffer with addVertexData
|
||||
public void testAddVertexExpansion()
|
||||
{
|
||||
BufferBuilder buffer = new BufferBuilder(BUFFER_SIZE / 4);
|
||||
int prevCap = buffer.getByteBuffer().capacity();
|
||||
|
||||
int[] ints = new int[3 * 4];// 3 floats per the 4 vertices.
|
||||
Arrays.fill(ints, Float.floatToIntBits(1.233F));//Just a random value.
|
||||
|
||||
buffer.begin(0x07, format);
|
||||
for (int i = 0; i < num_quads + 2; i++)
|
||||
{
|
||||
buffer.addVertexData(ints);
|
||||
}
|
||||
buffer.finishDrawing();
|
||||
|
||||
assertTrue("BufferBuilder's capacity didn't change.", buffer.getByteBuffer().capacity() > prevCap);
|
||||
}
|
||||
|
||||
@Test//Test the expansion of the buffer with endVertex.
|
||||
public void testEndVertexExpansion()
|
||||
{
|
||||
BufferBuilder buffer = new BufferBuilder(BUFFER_SIZE / 4);
|
||||
int prevCap = buffer.getByteBuffer().capacity();
|
||||
|
||||
buffer.begin(0x07, format);
|
||||
for (int i = 0; i < num_quads + 2; i++)
|
||||
{
|
||||
for (int j = 0; j < 4; j++)
|
||||
{
|
||||
buffer.pos(1.233, 1.233, 1.233).endVertex();
|
||||
}
|
||||
}
|
||||
buffer.finishDrawing();
|
||||
|
||||
assertTrue("BufferBuilder's capacity didn't change.", buffer.getByteBuffer().capacity() > prevCap);
|
||||
}
|
||||
|
||||
@Test//Test the expansion of the buffer if addVertexData fills it and pos / tex / endVertex is used.
|
||||
public void testMixedExpansion()
|
||||
{
|
||||
BufferBuilder buffer = new BufferBuilder(BUFFER_SIZE / 4);
|
||||
int prevCap = buffer.getByteBuffer().capacity();
|
||||
|
||||
int[] ints = new int[3 * 4];
|
||||
Arrays.fill(ints, Float.floatToIntBits(1.233F));
|
||||
|
||||
buffer.begin(0x07, format);
|
||||
for (int i = 0; i < num_quads; i++)
|
||||
{
|
||||
buffer.addVertexData(ints);
|
||||
}
|
||||
|
||||
for (int i = 0; i < num_quads + 2; i++)
|
||||
{
|
||||
for (int j = 0; j < 4; j++)
|
||||
{
|
||||
buffer.pos(1.233, 1.233, 1.233).endVertex();
|
||||
}
|
||||
}
|
||||
buffer.finishDrawing();
|
||||
|
||||
assertTrue("BufferBuilder's capacity didn't change.", buffer.getByteBuffer().capacity() > prevCap);
|
||||
}
|
||||
|
||||
}
|
||||
Reference in new issue
Block a user