From ad202e2e83efa3da9443e15ad5d6bae0869a8c26 Mon Sep 17 00:00:00 2001 From: Ben Staddon Date: Sat, 11 Nov 2017 23:19:00 +0000 Subject: [PATCH] Fix network buffers not being released in some places (#4510) --- .../fml/common/network/FMLIndexedMessageToMessageCodec.java | 1 + .../fml/common/network/handshake/ChannelRegistrationHandler.java | 1 + 2 files changed, 2 insertions(+) diff --git a/src/main/java/net/minecraftforge/fml/common/network/FMLIndexedMessageToMessageCodec.java b/src/main/java/net/minecraftforge/fml/common/network/FMLIndexedMessageToMessageCodec.java index 1318f8f31a..1244a2ac01 100644 --- a/src/main/java/net/minecraftforge/fml/common/network/FMLIndexedMessageToMessageCodec.java +++ b/src/main/java/net/minecraftforge/fml/common/network/FMLIndexedMessageToMessageCodec.java @@ -100,6 +100,7 @@ public abstract class FMLIndexedMessageToMessageCodec extends MessageToMessag ctx.channel().attr(INBOUNDPACKETTRACKER).get().set(new WeakReference(msg)); decodeInto(ctx, payload.slice(), newMsg); out.add(newMsg); + payload.release(); } /** diff --git a/src/main/java/net/minecraftforge/fml/common/network/handshake/ChannelRegistrationHandler.java b/src/main/java/net/minecraftforge/fml/common/network/handshake/ChannelRegistrationHandler.java index c42021c6ee..d6074a145c 100644 --- a/src/main/java/net/minecraftforge/fml/common/network/handshake/ChannelRegistrationHandler.java +++ b/src/main/java/net/minecraftforge/fml/common/network/handshake/ChannelRegistrationHandler.java @@ -47,6 +47,7 @@ public class ChannelRegistrationHandler extends SimpleChannelInboundHandler channelSet = ImmutableSet.copyOf(split); FMLCommonHandler.instance().fireNetRegistrationEvent(manager, channelSet, msg.channel(), side); + msg.payload().release(); } else {