From 84ab9764e3c4dee076b98877c00b049f85115109 Mon Sep 17 00:00:00 2001 From: sciwhiz12 Date: Wed, 9 Nov 2022 04:17:00 +0800 Subject: [PATCH] Throw aggregate exception for erroneous registry event dispatch (#9111) This means that exceptions occurring during the dispatch of the registry events, such as those from the suppliers of RegistryObjects, properly cause a crash rather than merely being logged and allowing the game to reach the main menu. Fixes #8720 --- src/main/java/net/minecraftforge/registries/GameData.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/net/minecraftforge/registries/GameData.java b/src/main/java/net/minecraftforge/registries/GameData.java index 5a9d73664d..96ee5b3f01 100644 --- a/src/main/java/net/minecraftforge/registries/GameData.java +++ b/src/main/java/net/minecraftforge/registries/GameData.java @@ -357,6 +357,7 @@ public class GameData LOGGER.fatal("Detected errors during registry event dispatch, rolling back to VANILLA state"); revertTo(RegistryManager.VANILLA, false); LOGGER.fatal("Detected errors during registry event dispatch, roll back to VANILLA complete"); + throw aggregate; } else { ForgeHooks.modifyAttributes();