From 6a06826b149192c72faca0bb68df35bc28238c18 Mon Sep 17 00:00:00 2001 From: TheBirdGang <67887622+TheBirdGang@users.noreply.github.com> Date: Wed, 18 Nov 2026 13:09:13 -0800 Subject: [PATCH] Fixed RemoveSpawnsBiomeModifier not properly functioning due to working on a copy of the biome info (#10925) --- .../common/world/ForgeBiomeModifiers.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/main/java/net/minecraftforge/common/world/ForgeBiomeModifiers.java b/src/main/java/net/minecraftforge/common/world/ForgeBiomeModifiers.java index e23ad6bbcb..fc313f7f71 100644 --- a/src/main/java/net/minecraftforge/common/world/ForgeBiomeModifiers.java +++ b/src/main/java/net/minecraftforge/common/world/ForgeBiomeModifiers.java @@ -213,7 +213,7 @@ public final class ForgeBiomeModifiers { *
Stock biome modifier that removes mob spawns from a biome. Has the following json format:
*
* {
- * "type": "forge:add_spawns", // Required
+ * "type": "forge:remove_spawns", // Required
* "biomes": "#namespace:biome_tag", // Accepts a biome id, [list of biome ids], or #namespace:biome_tag
* "entity_types": #namespace:entitytype_tag // Accepts an entity type, [list of entity types], or #namespace:entitytype_tag
* }
@@ -234,8 +234,12 @@ public final class ForgeBiomeModifiers {
if (phase == Phase.REMOVE && this.biomes.contains(biome)) {
var spawns = get(builder);
if (spawns != null) {
- for (var category : MobCategory.values())
- spawns.getSpawner(category).removeIf(data -> this.entityTypes.contains(ForgeRegistries.ENTITY_TYPES.getHolder(data.type()).orElseThrow()));
+ for (var category : spawns.getSpawnerTypes()) {
+ var newSpawns =
+ spawns.getSpawner(category).removeIf(data -> this.entityTypes.contains(ForgeRegistries.ENTITY_TYPES.getHolder(data.type()).orElseThrow()));
+ spawns.noSpawns(category);
+ spawns.addAllSpawns(category, newSpawns.build());
+ }
set(builder, spawns);
}
}