From 229848a4cb49a4577357bb1c9dfcad736a022584 Mon Sep 17 00:00:00 2001 From: Lex Manos Date: Sat, 8 Nov 2014 15:13:59 -0800 Subject: [PATCH] Add details message to MissingModsException and WrongMinecraftVersionException to make the Crash logs more useful. --- fml/src/main/java/net/minecraftforge/fml/common/Loader.java | 4 ++-- .../net/minecraftforge/fml/common/MissingModsException.java | 3 ++- .../fml/common/WrongMinecraftVersionException.java | 1 + 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/fml/src/main/java/net/minecraftforge/fml/common/Loader.java b/fml/src/main/java/net/minecraftforge/fml/common/Loader.java index 9ecc0a3fb8..309d93ee56 100644 --- a/fml/src/main/java/net/minecraftforge/fml/common/Loader.java +++ b/fml/src/main/java/net/minecraftforge/fml/common/Loader.java @@ -224,7 +224,7 @@ public class Loader { versionMissingMods.add(names.get(modid)); } - throw new MissingModsException(versionMissingMods); + throw new MissingModsException(versionMissingMods, mod.getModId(), mod.getName()); } reqList.putAll(mod.getModId(), names.keySet()); ImmutableList allDeps = ImmutableList.builder().addAll(mod.getDependants()).addAll(mod.getDependencies()).build(); @@ -241,7 +241,7 @@ public class Loader if (!versionMissingMods.isEmpty()) { FMLLog.severe("The mod %s (%s) requires mod versions %s to be available", mod.getModId(), mod.getName(), versionMissingMods); - throw new MissingModsException(versionMissingMods); + throw new MissingModsException(versionMissingMods, mod.getModId(), mod.getName()); } } diff --git a/fml/src/main/java/net/minecraftforge/fml/common/MissingModsException.java b/fml/src/main/java/net/minecraftforge/fml/common/MissingModsException.java index 80811d94ed..cafbbe1ea8 100644 --- a/fml/src/main/java/net/minecraftforge/fml/common/MissingModsException.java +++ b/fml/src/main/java/net/minecraftforge/fml/common/MissingModsException.java @@ -21,8 +21,9 @@ public class MissingModsException extends RuntimeException private static final long serialVersionUID = 1L; public final Set missingMods; - public MissingModsException(Set missingMods) + public MissingModsException(Set missingMods, String id, String name) { + super(String.format("Mod %s (%s) requires %s", id, name, missingMods)); this.missingMods = missingMods; } } diff --git a/fml/src/main/java/net/minecraftforge/fml/common/WrongMinecraftVersionException.java b/fml/src/main/java/net/minecraftforge/fml/common/WrongMinecraftVersionException.java index 36a5e04487..4037fb7cd2 100644 --- a/fml/src/main/java/net/minecraftforge/fml/common/WrongMinecraftVersionException.java +++ b/fml/src/main/java/net/minecraftforge/fml/common/WrongMinecraftVersionException.java @@ -19,6 +19,7 @@ public class WrongMinecraftVersionException extends RuntimeException public WrongMinecraftVersionException(ModContainer mod) { + super(String.format("Wrong Minecraft vbersion for %s", mod.getModId())); this.mod = mod; }