Formatting and code readability cleanup (#5467)

* First pass reformatting code to be more readable (common still not done)

* Replace google common collect calls with Java calls where possible

* Remove a bunch of unnecessary parenthesis leaving clarifying ones

* Add some missing @Nonnull annotations

* Fix checking wrong type

* Remove unnecessary continue/return statements and simplify comparision check

* Pass exception instead of directly printing stack trace

* Work on cleaning up common, through config so far

* Work on cleaning up common, through integration so far

* Work on cleaning up common, through network so far

* Work on cleaning up common, through tier so far

* Remove empty constructors that get created by default anyways

* Work on cleaning up common, through transmitters so far

* Work on cleaning up common, through utils so far

* Finish cleaning up spacing for common
This commit is contained in:
Richard Freimer authored and GitHub committed 2019-05-11 14:13:24 -04:00
1 parent 91ef2a5c3d
commit 0d4b50908f
909 files changed
+6234 -15623

No files matched your search

@@ -16,20 +16,15 @@ public class PacketPortalFX implements IMessageHandler<PortalFXMessage, IMessage
@Override
public IMessage onMessage(PortalFXMessage message, MessageContext context) {
EntityPlayer player = PacketHandler.getPlayer(context);
PacketHandler.handlePacket(() ->
{
PacketHandler.handlePacket(() -> {
Random random = new Random();
for (int i = 0; i < 50; i++) {
player.world.spawnParticle(EnumParticleTypes.PORTAL, message.coord4D.x + random.nextFloat(),
message.coord4D.y + random.nextFloat(), message.coord4D.z + random.nextFloat(), 0.0F, 0.0F, 0.0F);
player.world.spawnParticle(EnumParticleTypes.PORTAL, message.coord4D.x + random.nextFloat(),
message.coord4D.y + 1 + random.nextFloat(), message.coord4D.z + random.nextFloat(), 0.0F, 0.0F,
0.0F);
player.world.spawnParticle(EnumParticleTypes.PORTAL, message.coord4D.x + random.nextFloat(), message.coord4D.y + random.nextFloat(),
message.coord4D.z + random.nextFloat(), 0.0F, 0.0F, 0.0F);
player.world.spawnParticle(EnumParticleTypes.PORTAL, message.coord4D.x + random.nextFloat(), message.coord4D.y + 1 + random.nextFloat(),
message.coord4D.z + random.nextFloat(), 0.0F, 0.0F, 0.0F);
}
}, player);
return null;
}
@@ -54,4 +49,4 @@ public class PacketPortalFX implements IMessageHandler<PortalFXMessage, IMessage
coord4D = Coord4D.read(dataStream);
}
}
}
}