From 699d50bfe3e0dfe5bbca2f38d1edcee0451f6dbe Mon Sep 17 00:00:00 2001 From: KnightMiner Date: Fri, 4 Jun 2021 17:56:36 -0400 Subject: [PATCH] Skip writting conditions if empty for the consumer wrapper --- .../mantle/recipe/data/ConsumerWrapperBuilder.java | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/main/java/slimeknights/mantle/recipe/data/ConsumerWrapperBuilder.java b/src/main/java/slimeknights/mantle/recipe/data/ConsumerWrapperBuilder.java index 75ba270..fcbfc41 100644 --- a/src/main/java/slimeknights/mantle/recipe/data/ConsumerWrapperBuilder.java +++ b/src/main/java/slimeknights/mantle/recipe/data/ConsumerWrapperBuilder.java @@ -83,7 +83,7 @@ public class ConsumerWrapperBuilder { @Nullable private final ResourceLocation overrideName; - private Wrapped(IFinishedRecipe original, List conditions, @Nullable IRecipeSerializer override, ResourceLocation overrideName) { + private Wrapped(IFinishedRecipe original, List conditions, @Nullable IRecipeSerializer override, @Nullable ResourceLocation overrideName) { this.original = original; this.conditions = conditions; this.override = override; @@ -105,11 +105,13 @@ public class ConsumerWrapperBuilder { @Override public void serialize(JsonObject json) { // add conditions on top - JsonArray conditionsArray = new JsonArray(); - for (ICondition condition : conditions) { - conditionsArray.add(CraftingHelper.serialize(condition)); + if (!conditions.isEmpty()) { + JsonArray conditionsArray = new JsonArray(); + for (ICondition condition : conditions) { + conditionsArray.add(CraftingHelper.serialize(condition)); + } + json.add("conditions", conditionsArray); } - json.add("conditions", conditionsArray); // serialize the normal recipe original.serialize(json); }