From 53d085d29248bab3c8e3f31de3de26349da148de Mon Sep 17 00:00:00 2001 From: boubou19 Date: Tue, 11 Aug 2026 02:54:09 +0200 Subject: [PATCH] Cache more enum `.values()` (#67) --- src/main/java/magicbees/item/ItemWax.java | 10 +++++----- src/main/java/magicbees/item/types/WaxType.java | 4 +++- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/main/java/magicbees/item/ItemWax.java b/src/main/java/magicbees/item/ItemWax.java index 3887262..afb36de 100644 --- a/src/main/java/magicbees/item/ItemWax.java +++ b/src/main/java/magicbees/item/ItemWax.java @@ -45,14 +45,14 @@ public class ItemWax extends Item { @Override @SideOnly(Side.CLIENT) public IIcon getIconFromDamage(int meta) { - return (WaxType.values()[meta].sparkly) ? this.itemIcon : this.secondaryIcon; + return (WaxType.VALUES[meta].sparkly) ? this.itemIcon : this.secondaryIcon; } @Override @SideOnly(Side.CLIENT) @SuppressWarnings({ "unchecked", "rawtypes" }) public void getSubItems(Item item, CreativeTabs tabs, List list) { - for (WaxType type : WaxType.values()) { + for (WaxType type : WaxType.VALUES) { list.add(this.getStackForType(type)); } } @@ -62,14 +62,14 @@ public class ItemWax extends Item { public int getColorFromItemStack(ItemStack stack, int pass) { int colour = 0xffffff; int meta = stack.getItemDamage(); - if (meta >= 0 && meta < WaxType.values().length) { - colour = WaxType.values()[meta].colour; + if (meta >= 0 && meta < WaxType.VALUES.length) { + colour = WaxType.VALUES[meta].colour; } return colour; } @Override public String getItemStackDisplayName(ItemStack stack) { - return WaxType.values()[stack.getItemDamage()].getName(); + return WaxType.VALUES[stack.getItemDamage()].getName(); } } diff --git a/src/main/java/magicbees/item/types/WaxType.java b/src/main/java/magicbees/item/types/WaxType.java index 6ba7f9c..dccb722 100644 --- a/src/main/java/magicbees/item/types/WaxType.java +++ b/src/main/java/magicbees/item/types/WaxType.java @@ -8,7 +8,9 @@ public enum WaxType { SOUL("soul", false, 0x967C63), AMNESIC("amnesic", true, 0x856DFF); - private WaxType(String n, boolean sp, int c) { + public static final WaxType[] VALUES = values(); + + WaxType(String n, boolean sp, int c) { this.name = n; this.sparkly = sp; this.colour = c;