From 46bccadca23e8c17e1546daae04063b4312f6e6b Mon Sep 17 00:00:00 2001 From: Evan Goode Date: Wed, 1 Jul 2020 08:47:47 -0600 Subject: [PATCH] Escape URLs, for usernames with spaces (#100) --- .../customskinloader/utils/HttpRequestUtil.java | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/Common/source/customskinloader/utils/HttpRequestUtil.java b/Common/source/customskinloader/utils/HttpRequestUtil.java index 38ae03a..44720d9 100644 --- a/Common/source/customskinloader/utils/HttpRequestUtil.java +++ b/Common/source/customskinloader/utils/HttpRequestUtil.java @@ -115,7 +115,17 @@ public class HttpRequestUtil { } //Init Connection - String url = new URI(request.url).toASCIIString(); + URL rawUrl = new URL(request.url); + URI uri = new URI( + rawUrl.getProtocol(), + rawUrl.getUserInfo(), + rawUrl.getHost(), + rawUrl.getPort(), + rawUrl.getPath(), + rawUrl.getQuery(), + rawUrl.getRef() + ); + String url = uri.toASCIIString(); if (!url.equalsIgnoreCase(request.url)) CustomSkinLoader.logger.debug("Encoded URL: " + url); HttpURLConnection c = (HttpURLConnection) (new URL(url)).openConnection();