From e5286092128733012f7d1e9885a6797a6e72db36 Mon Sep 17 00:00:00 2001 From: mezz Date: Tue, 11 Nov 2014 19:07:47 -0800 Subject: [PATCH] Minor code cleanup --- .../forestry/core/utils/ShapedRecipeCustom.java | 2 +- .../factory/gadgets/MachineCentrifuge.java | 15 +++++++-------- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/src/main/java/forestry/core/utils/ShapedRecipeCustom.java b/src/main/java/forestry/core/utils/ShapedRecipeCustom.java index bb1460a45..5ca111b38 100755 --- a/src/main/java/forestry/core/utils/ShapedRecipeCustom.java +++ b/src/main/java/forestry/core/utils/ShapedRecipeCustom.java @@ -135,7 +135,7 @@ public class ShapedRecipeCustom implements IDescriptiveRecipe { if (resource == null && compare == null) return true; - if (resource == null && compare != null || resource != null && compare == null) + if (resource == null || compare == null) return false; if (compare.getItem() != resource.getItem()) diff --git a/src/main/java/forestry/factory/gadgets/MachineCentrifuge.java b/src/main/java/forestry/factory/gadgets/MachineCentrifuge.java index e213978bd..dbf8f03f2 100755 --- a/src/main/java/forestry/factory/gadgets/MachineCentrifuge.java +++ b/src/main/java/forestry/factory/gadgets/MachineCentrifuge.java @@ -64,9 +64,7 @@ public class MachineCentrifuge extends TilePowered implements ISidedInventory, I public boolean matches(ItemStack res) { if (res == null && resource == null) return true; - else if (res == null && resource != null) - return false; - else if (res != null && resource == null) + else if (res == null || resource == null) return false; else return resource.isItemEqual(res); @@ -428,10 +426,11 @@ public class MachineCentrifuge extends TilePowered implements ISidedInventory, I ItemStack product = null; for (int i = SLOT_PRODUCT_1; i < inventory.getSizeInventory(); i++) { - if (inventory.getStackInSlot(i) == null) + ItemStack stack = inventory.getStackInSlot(i); + if (stack == null) continue; - product = new ItemStack(inventory.getStackInSlot(i).getItem(), 1, inventory.getStackInSlot(i).getItemDamage()); + product = StackUtils.createSplitStack(stack, 1); if (doRemove) decrStackSize(i, 1); @@ -456,15 +455,15 @@ public class MachineCentrifuge extends TilePowered implements ISidedInventory, I if (!StackUtils.isIdenticalItem(resource, stack)) return 0; - int space = inventory.getStackInSlot(SLOT_RESOURCE).getMaxStackSize() - inventory.getStackInSlot(SLOT_RESOURCE).stackSize; + int space = resource.getMaxStackSize() - resource.stackSize; if (space <= 0) return 0; if (doAdd) if (stack.stackSize <= space) - inventory.getStackInSlot(SLOT_RESOURCE).stackSize += stack.stackSize; + resource.stackSize += stack.stackSize; else - inventory.getStackInSlot(SLOT_RESOURCE).stackSize += space; + resource.stackSize += space; return Math.min(stack.stackSize, space); }