Revert "Slightly improve render performance of genetic items (bee, trees, etc)"

This reverts commit 3df3d9121e.
This commit is contained in:
mezz committed 2017-11-29 22:00:21 -08:00
1 parent 13f49fc930
commit b07e5a1556
6 files changed
+12 -10

No files matched your search

@@ -1,6 +1,7 @@
package forestry.apiculture.compat;
import com.google.common.base.Preconditions;
import forestry.api.apiculture.BeeManager;
import forestry.api.genetics.IAlleleSpecies;
import forestry.apiculture.ModuleApiculture;
import forestry.apiculture.items.ItemRegistryApiculture;
@@ -19,7 +20,7 @@ public class ApicultureJeiPlugin implements IModPlugin {
Preconditions.checkNotNull(items);
ISubtypeRegistry.ISubtypeInterpreter beeSubtypeInterpreter = itemStack -> {
IAlleleSpecies species = Genome.getSpeciesDirectly(itemStack);
IAlleleSpecies species = Genome.getSpeciesDirectly(BeeManager.beeRoot, itemStack);
return species == null ? ISubtypeRegistry.ISubtypeInterpreter.NONE : species.getUID();
};
@@ -84,7 +84,7 @@ public class BeeGenome extends Genome implements IBeeGenome {
public static IAlleleBeeSpecies getSpecies(ItemStack itemStack) {
Preconditions.checkArgument(BeeManager.beeRoot.isMember(itemStack), "itemStack must be a bee");
IAlleleSpecies species = getSpeciesDirectly(itemStack);
IAlleleSpecies species = getSpeciesDirectly(BeeManager.beeRoot, itemStack);
if (species instanceof IAlleleBeeSpecies) {
return (IAlleleBeeSpecies) species;
}
@@ -48,7 +48,7 @@ public class TreeGenome extends Genome implements ITreeGenome {
public static IAlleleTreeSpecies getSpecies(ItemStack itemStack) {
Preconditions.checkArgument(TreeManager.treeRoot.isMember(itemStack), "ItemStack must be a tree");
IAlleleSpecies species = getSpeciesDirectly(itemStack);
IAlleleSpecies species = getSpeciesDirectly(TreeManager.treeRoot, itemStack);
if (species instanceof IAlleleTreeSpecies) {
return (IAlleleTreeSpecies) species;
}
@@ -22,8 +22,8 @@ import forestry.api.genetics.IChromosomeType;
import forestry.api.genetics.ISpeciesRoot;
public class Chromosome implements IChromosome {
public static final String UID0_TAG = "UID0";
public static final String UID1_TAG = "UID1";
private static final String UID0_TAG = "UID0";
private static final String UID1_TAG = "UID1";
private final IAllele primary;
private final IAllele secondary;
@@ -15,7 +15,6 @@ import com.google.common.base.MoreObjects;
import javax.annotation.Nullable;
import java.util.Arrays;
import forestry.api.genetics.AlleleManager;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
@@ -110,7 +109,7 @@ public abstract class Genome implements IGenome {
* We need this because the client uses the species for rendering.
*/
@Nullable
public static IAlleleSpecies getSpeciesDirectly(ItemStack itemStack) {
public static IAlleleSpecies getSpeciesDirectly(ISpeciesRoot speciesRoot, ItemStack itemStack) {
NBTTagCompound nbtTagCompound = itemStack.getTagCompound();
if (nbtTagCompound == null) {
return null;
@@ -127,11 +126,13 @@ public abstract class Genome implements IGenome {
}
NBTTagCompound chromosomeNBT = chromosomesNBT.getCompoundTagAt(0);
String speciesUid = chromosomeNBT.getString(Chromosome.UID0_TAG);
IAllele activeAllele = AlleleManager.alleleRegistry.getAllele(speciesUid);
Chromosome chromosome = Chromosome.create(null, null, speciesRoot.getSpeciesChromosomeType(), chromosomeNBT);
IAllele activeAllele = chromosome.getActiveAllele();
if (!(activeAllele instanceof IAlleleSpecies)) {
return null;
}
return (IAlleleSpecies) activeAllele;
}
@@ -49,7 +49,7 @@ public class ButterflyGenome extends Genome implements IButterflyGenome {
public static IAlleleButterflySpecies getSpecies(ItemStack itemStack) {
Preconditions.checkArgument(ButterflyManager.butterflyRoot.isMember(itemStack), "Must be a butterfly");
IAlleleSpecies species = getSpeciesDirectly(itemStack);
IAlleleSpecies species = getSpeciesDirectly(ButterflyManager.butterflyRoot, itemStack);
if (species instanceof IAlleleButterflySpecies) {
return (IAlleleButterflySpecies) species;
}