Cache frequent Enum#values() calls (#107)

This commit is contained in:
Alexdoru authored and GitHub committed 2026-03-03 21:22:36 +01:00
1 parent 7e1398438d
commit 3fb58ad6a5
31 files changed
+162 -122

No files matched your search

@@ -45,8 +45,17 @@ public enum EnumFarmBlockTexture {
private static final int TYPE_VALVE = 6;
private static final int TYPE_CONTROL = 7;
/**
* Cached values() array for frequent read-only operations, the array should NOT be mutated.
*/
public static final EnumFarmBlockTexture[] VALUES = values();
@SideOnly(Side.CLIENT)
private static List<IIcon> icons;
private final ItemStack base;
EnumFarmBlockTexture(ItemStack base) {
this.base = base;
}
@SideOnly(Side.CLIENT)
public static void registerIcons(IIconRegister register) {
@@ -61,12 +70,6 @@ public enum EnumFarmBlockTexture {
TextureManager.registerTex(register, "farm/control"));
}
private final ItemStack base;
EnumFarmBlockTexture(ItemStack base) {
this.base = base;
}
@SideOnly(Side.CLIENT)
public static IIcon getIcon(BlockFarmType type, int side) {
switch (type) {
@@ -109,11 +112,10 @@ public enum EnumFarmBlockTexture {
public static EnumFarmBlockTexture getFromCompound(NBTTagCompound compound) {
if (compound != null) {
int farmBlockOrdinal = compound.getInteger("FarmBlock");
if (farmBlockOrdinal < EnumFarmBlockTexture.values().length) {
return EnumFarmBlockTexture.values()[farmBlockOrdinal];
if (farmBlockOrdinal < EnumFarmBlockTexture.VALUES.length) {
return EnumFarmBlockTexture.VALUES[farmBlockOrdinal];
}
}
return EnumFarmBlockTexture.BRICK_STONE;
}
}