Optimized NBT access of player data when checking quest completion, player data variable is passed down to lower functions.

Player's quests are checked for completion every couple seconds now.
This commit is contained in:
luisc committed 2022-02-02 07:18:33 -06:00
1 parent 632e92f82e
commit 1ebf747302
13 files changed
+70 -69

No files matched your search

@@ -291,11 +291,12 @@ public class ServerEventsHandler {
}
private void doQuest(EntityPlayer player, EntityLivingBase entity, boolean all) {
PlayerQuestData playerdata = PlayerDataController.instance.getPlayerData(player).questData;
PlayerData playerData = PlayerDataController.instance.getPlayerData(player);
PlayerQuestData questData = playerData.questData;
boolean change = false;
String entityName = EntityList.getEntityString(entity);
for(QuestData data : playerdata.activeQuests.values()){
for(QuestData data : questData.activeQuests.values()){
if(data.quest.type != EnumQuestType.Kill && data.quest.type != EnumQuestType.AreaKill)
continue;
if(data.quest.type == EnumQuestType.AreaKill && all){
@@ -326,15 +327,16 @@ public class ServerEventsHandler {
if(!change)
return;
playerdata.checkQuestCompletion(player,EnumQuestType.Kill);
questData.checkQuestCompletion(playerData,EnumQuestType.Kill);
}
@SubscribeEvent
public void pickUp(EntityItemPickupEvent event){
if(event.entityPlayer.worldObj.isRemote)
return;
PlayerQuestData playerdata = PlayerDataController.instance.getPlayerData(event.entityPlayer).questData;
playerdata.checkQuestCompletion(event.entityPlayer, EnumQuestType.Item);
PlayerData playerData = PlayerDataController.instance.getPlayerData(event.entityPlayer);
PlayerQuestData questData = playerData.questData;
questData.checkQuestCompletion(playerData, EnumQuestType.Item);
}
@SubscribeEvent