From 4001d105a8b4170a926e55fad92821a98b84c400 Mon Sep 17 00:00:00 2001 From: boubou19 Date: Thu, 17 Jul 2025 19:17:22 +0200 Subject: [PATCH] Speed up forge event registration (#62) --- .../java/team/chisel/block/BlockConcrete.java | 43 ++++++++++--------- .../team/chisel/item/chisel/ItemChisel.java | 2 - 2 files changed, 23 insertions(+), 22 deletions(-) diff --git a/src/main/java/team/chisel/block/BlockConcrete.java b/src/main/java/team/chisel/block/BlockConcrete.java index 42e9857e..396be05b 100644 --- a/src/main/java/team/chisel/block/BlockConcrete.java +++ b/src/main/java/team/chisel/block/BlockConcrete.java @@ -21,31 +21,34 @@ public class BlockConcrete extends BlockCarvable { super(); FMLCommonHandler.instance() .bus() - .register(this); + .register(new EventHandler()); } @SideOnly(Side.CLIENT) private static MovementInput manualInputCheck; - @SubscribeEvent - @SideOnly(Side.CLIENT) - public void speedupPlayer(PlayerTickEvent event) { - if (event.phase == Phase.START && event.side.isClient() - && event.player.onGround - && event.player instanceof EntityPlayerSP) { - if (manualInputCheck == null) { - manualInputCheck = new MovementInputFromOptions(Minecraft.getMinecraft().gameSettings); - } - EntityPlayerSP player = (EntityPlayerSP) event.player; - Block below = player.worldObj.getBlock( - MathHelper.floor_double(player.posX), - MathHelper.floor_double(player.posY) - 2, - MathHelper.floor_double(player.posZ)); - if (below == this) { - manualInputCheck.updatePlayerMoveState(); - if (manualInputCheck.moveForward != 0 || manualInputCheck.moveStrafe != 0) { - player.motionX *= Configurations.concreteVelocityMult + 0.05; - player.motionZ *= Configurations.concreteVelocityMult + 0.05; + public class EventHandler { + + @SubscribeEvent + @SideOnly(Side.CLIENT) + public void speedupPlayer(PlayerTickEvent event) { + if (event.phase == Phase.START && event.side.isClient() + && event.player.onGround + && event.player instanceof EntityPlayerSP) { + if (manualInputCheck == null) { + manualInputCheck = new MovementInputFromOptions(Minecraft.getMinecraft().gameSettings); + } + EntityPlayerSP player = (EntityPlayerSP) event.player; + Block below = player.worldObj.getBlock( + MathHelper.floor_double(player.posX), + MathHelper.floor_double(player.posY) - 2, + MathHelper.floor_double(player.posZ)); + if (below == BlockConcrete.this) { + manualInputCheck.updatePlayerMoveState(); + if (manualInputCheck.moveForward != 0 || manualInputCheck.moveStrafe != 0) { + player.motionX *= Configurations.concreteVelocityMult + 0.05; + player.motionZ *= Configurations.concreteVelocityMult + 0.05; + } } } } diff --git a/src/main/java/team/chisel/item/chisel/ItemChisel.java b/src/main/java/team/chisel/item/chisel/ItemChisel.java index 24e96931..cd6514f5 100644 --- a/src/main/java/team/chisel/item/chisel/ItemChisel.java +++ b/src/main/java/team/chisel/item/chisel/ItemChisel.java @@ -14,7 +14,6 @@ import net.minecraft.init.Items; import net.minecraft.item.Item; import net.minecraft.item.ItemStack; import net.minecraft.world.World; -import net.minecraftforge.common.MinecraftForge; import com.cricketcraft.chisel.api.IChiselItem; import com.cricketcraft.chisel.api.carving.ICarvingRegistry; @@ -68,7 +67,6 @@ public class ItemChisel extends Item implements IChiselItem { + type.name() .toLowerCase()); } - MinecraftForge.EVENT_BUS.register(this); } @Override