From ab633fb4190520bc72477c46c0342c1c7f1a5b59 Mon Sep 17 00:00:00 2001 From: Matthias Mann Date: Fri, 13 Nov 2015 09:03:54 +0100 Subject: [PATCH 1/2] avoid unnecessary object allocation --- .../vazkii/botania/common/core/helper/InventoryHelper.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/vazkii/botania/common/core/helper/InventoryHelper.java b/src/main/java/vazkii/botania/common/core/helper/InventoryHelper.java index 745fefb18..d553eda94 100644 --- a/src/main/java/vazkii/botania/common/core/helper/InventoryHelper.java +++ b/src/main/java/vazkii/botania/common/core/helper/InventoryHelper.java @@ -84,7 +84,7 @@ public class InventoryHelper { } int i = 0; - int[] attemptSlots = new int[0]; + int[] attemptSlots; if(inventory instanceof ISidedInventory && side != ForgeDirection.UNKNOWN) { attemptSlots = ((ISidedInventory)inventory).getAccessibleSlotsFromSide(side.ordinal()); @@ -127,7 +127,7 @@ public class InventoryHelper { inventory.getSizeInventory(); int itemSizeCounter = item.stackSize; - int[] availableSlots = new int[0]; + int[] availableSlots; if(inventory instanceof ISidedInventory) availableSlots = ((ISidedInventory) inventory).getAccessibleSlotsFromSide(side.ordinal()); From 683ae951c3fcb74ef7e0d60ad1a4800dbfdd25a9 Mon Sep 17 00:00:00 2001 From: Vasco Lavos Date: Fri, 13 Nov 2015 13:00:27 +0000 Subject: [PATCH 2/2] Update contributing.md --- contributing.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contributing.md b/contributing.md index a9a190613..7edd52275 100644 --- a/contributing.md +++ b/contributing.md @@ -7,7 +7,8 @@ Hey there. Looks like you want to contribute with an issue. Great. Here's what y * Unless you manually update every mod on the pack to the latest, issues regarding any public modpack that is not officially maintained or supported by the botania developers (the ones in the modpack section of the website are not) are **not accepted**; * Duplicate issues or issues that have been solved already (use the search feature!) will be closed without asking. * Do not tag your issues' names. "Something Broke" is prefered to "[Bug] Something Broke" because there's a proper label system in place. - * Post suggestions or ideas on reddit or the forums. This is for bugs, not ideas. + * Post suggestions or ideas on reddit or the forums. This is for bugs, not ideas. Unless I really like them and want to keep the issue open as a reminder (unlikely), they'll be closed without comment. + * If you ARE going to post a suggestion, which you shouldn't, post ONE, not a wishlist. The following "bugs" are not accepted: * Intended Behaviour