From 34280c942bc264f5c25a7e29d2736c3c2503b30b Mon Sep 17 00:00:00 2001 From: Vincent Lee Date: Mon, 19 Mar 2018 22:26:31 -0500 Subject: [PATCH] Fix particles 'snapping into place', a vanilla bug. Closes #2217 --- src/main/java/vazkii/botania/client/fx/FXSparkle.java | 7 +++++++ src/main/java/vazkii/botania/client/fx/FXWisp.java | 7 +++++++ 2 files changed, 14 insertions(+) diff --git a/src/main/java/vazkii/botania/client/fx/FXSparkle.java b/src/main/java/vazkii/botania/client/fx/FXSparkle.java index 005f51ee3..eaa632994 100644 --- a/src/main/java/vazkii/botania/client/fx/FXSparkle.java +++ b/src/main/java/vazkii/botania/client/fx/FXSparkle.java @@ -160,6 +160,13 @@ public class FXSparkle extends Particle { setExpired(); } + @Override + protected void setSize(float width, float height) { + super.setSize(width, height); + // fix MC-12269: the bb is expanded only in +X +Z directions by super, call setPosition again to recalculate a correct BB + setPosition(posX, posY, posZ); + } + public void setGravity(float value) { particleGravity = value; } diff --git a/src/main/java/vazkii/botania/client/fx/FXWisp.java b/src/main/java/vazkii/botania/client/fx/FXWisp.java index 0642f680c..904177a68 100644 --- a/src/main/java/vazkii/botania/client/fx/FXWisp.java +++ b/src/main/java/vazkii/botania/client/fx/FXWisp.java @@ -158,6 +158,13 @@ public class FXWisp extends Particle { this.motionZ *= 0.9800000190734863D; } + @Override + protected void setSize(float width, float height) { + super.setSize(width, height); + // fix MC-12269: the bb is expanded only in +X +Z directions by super, call setPosition again to recalculate a correct BB + setPosition(posX, posY, posZ); + } + public void setGravity(float value) { particleGravity = value; }