From 65e11fa5642faf7292c61da29272a72d16daea9e Mon Sep 17 00:00:00 2001 From: TweksTY <59334540+TweksTY@users.noreply.github.com> Date: Sat, 21 Mar 2026 04:56:15 +0100 Subject: [PATCH] Fix Genetics machines' VFX incorrectly appearing at 0;0;0 coordinates (#89) Co-authored-by: UltraProdigy <187078471+UltraProdigy@users.noreply.github.com> --- .../genetics/machine/analyser/AnalyserComponentFX.java | 7 ------- .../genetics/machine/inoculator/InoculatorComponentFX.java | 3 --- .../genetics/machine/isolator/IsolatorComponentFX.java | 6 +++--- .../machine/polymeriser/PolymeriserComponentFX.java | 3 --- .../genetics/machine/sequencer/SequencerComponentFX.java | 3 --- .../genetics/machine/splicer/SplicerComponentFX.java | 3 --- 6 files changed, 3 insertions(+), 22 deletions(-) diff --git a/src/main/java/binnie/genetics/machine/analyser/AnalyserComponentFX.java b/src/main/java/binnie/genetics/machine/analyser/AnalyserComponentFX.java index d17e6165..5d47d898 100644 --- a/src/main/java/binnie/genetics/machine/analyser/AnalyserComponentFX.java +++ b/src/main/java/binnie/genetics/machine/analyser/AnalyserComponentFX.java @@ -43,14 +43,7 @@ public class AnalyserComponentFX extends MachineComponent BinnieCore.proxy.getMinecraftInstance().effectRenderer .addEffect(new EntityFX(world, x + 0.5, y + 1.3 + rand.nextDouble() * 0.2, z + 0.5, 0.0, 0.0, 0.0) { - double axisX = posX; - double axisZ = posZ; - double angle = rand.nextDouble() * 2.0 * 3.1415; - { - axisX = 0.0; - axisZ = 0.0; - angle = 0.0; motionX = 0.05 * (rand.nextDouble() - 0.5); motionZ = 0.05 * (rand.nextDouble() - 0.5); motionY = 0.0; diff --git a/src/main/java/binnie/genetics/machine/inoculator/InoculatorComponentFX.java b/src/main/java/binnie/genetics/machine/inoculator/InoculatorComponentFX.java index 1578fd00..32409f57 100644 --- a/src/main/java/binnie/genetics/machine/inoculator/InoculatorComponentFX.java +++ b/src/main/java/binnie/genetics/machine/inoculator/InoculatorComponentFX.java @@ -48,9 +48,6 @@ public class InoculatorComponentFX extends MachineComponent double angle = (int) (worldObj.getTotalWorldTime() % 4L) * 0.5 * 3.1415; { - axisX = 0.0; - axisZ = 0.0; - angle = 0.0; motionX = 0.0; motionZ = 0.0; motionY = 0.007 + rand.nextDouble() * 0.002; diff --git a/src/main/java/binnie/genetics/machine/isolator/IsolatorComponentFX.java b/src/main/java/binnie/genetics/machine/isolator/IsolatorComponentFX.java index 30cc83e8..39b6df6a 100644 --- a/src/main/java/binnie/genetics/machine/isolator/IsolatorComponentFX.java +++ b/src/main/java/binnie/genetics/machine/isolator/IsolatorComponentFX.java @@ -65,10 +65,10 @@ public class IsolatorComponentFX extends MachineComponent implements IRender.Ran } BinnieCore.proxy.getMinecraftInstance().effectRenderer - .addEffect(new EntityFX(world, x + 0.5, y + 1, z + 0.5, 0.0, 0.0, 0.0) { + .addEffect(new EntityFX(world, x + 0.5, y + 1, z + 0.75, 0.0, 0.0, 0.0) { - final double axisX = 0.0; - final double axisZ = 0.0; + final double axisX = posX; + final double axisZ = posZ - 0.25; double angle = 0.0; { diff --git a/src/main/java/binnie/genetics/machine/polymeriser/PolymeriserComponentFX.java b/src/main/java/binnie/genetics/machine/polymeriser/PolymeriserComponentFX.java index 8e43b6e0..16fc03a0 100644 --- a/src/main/java/binnie/genetics/machine/polymeriser/PolymeriserComponentFX.java +++ b/src/main/java/binnie/genetics/machine/polymeriser/PolymeriserComponentFX.java @@ -37,9 +37,6 @@ public class PolymeriserComponentFX extends MachineComponent implements IRender. double angle = 0.7 + (int) (worldObj.getTotalWorldTime() % 2L) * 3.1415; { - axisX = 0.0; - axisZ = 0.0; - angle = 0.0; motionX = 0.0; motionZ = 0.0; motionY = -0.006; diff --git a/src/main/java/binnie/genetics/machine/sequencer/SequencerComponentFX.java b/src/main/java/binnie/genetics/machine/sequencer/SequencerComponentFX.java index 1cc03f64..2038fb85 100644 --- a/src/main/java/binnie/genetics/machine/sequencer/SequencerComponentFX.java +++ b/src/main/java/binnie/genetics/machine/sequencer/SequencerComponentFX.java @@ -34,9 +34,6 @@ public class SequencerComponentFX extends MachineComponent implements IRender.Ra double angle = rand.nextDouble() * 2.0 * 3.1415; { - axisX = 0.0; - axisZ = 0.0; - angle = 0.0; motionX = 0.0; motionZ = 0.0; motionY = 0.0; diff --git a/src/main/java/binnie/genetics/machine/splicer/SplicerComponentFX.java b/src/main/java/binnie/genetics/machine/splicer/SplicerComponentFX.java index 7b943346..627354dc 100644 --- a/src/main/java/binnie/genetics/machine/splicer/SplicerComponentFX.java +++ b/src/main/java/binnie/genetics/machine/splicer/SplicerComponentFX.java @@ -49,9 +49,6 @@ public class SplicerComponentFX extends MachineComponent double angle = (int) (worldObj.getTotalWorldTime() % 4L) * 0.5 * 3.1415; { - axisX = 0.0; - axisZ = 0.0; - angle = 0.0; motionX = 0.0; motionZ = 0.0; motionY = (rand.nextDouble() - 0.5) * 0.02;