From ffcc5f71027f9420bbed3d5436e0465852d05229 Mon Sep 17 00:00:00 2001 From: Alexdoru <57050655+Alexdoru@users.noreply.github.com> Date: Mon, 1 Dec 2025 23:35:01 +0100 Subject: [PATCH] [Memory-opti:runtime allocations] Reduce amount of NBTTagCompound created in TileEntityMetadata#getItemStack (#77) --- .../java/binnie/core/block/TileEntityMetadata.java | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/main/java/binnie/core/block/TileEntityMetadata.java b/src/main/java/binnie/core/block/TileEntityMetadata.java index ea511f02..25f002d1 100644 --- a/src/main/java/binnie/core/block/TileEntityMetadata.java +++ b/src/main/java/binnie/core/block/TileEntityMetadata.java @@ -76,12 +76,14 @@ public class TileEntityMetadata extends TileEntity { } public static ItemStack getItemStack(Block block, int damage) { - NBTTagCompound tag = new NBTTagCompound(); - tag.setInteger("meta", damage); - ItemStack item = new ItemStack(block, 1, 0); - item.setItemDamage(Math.min(damage, 16387)); - item.setTagCompound(tag); + if (0 <= damage && damage < Short.MAX_VALUE) { + item.setItemDamage(damage); + } else { + NBTTagCompound tag = new NBTTagCompound(); + tag.setInteger("meta", damage); + item.setTagCompound(tag); + } return item; }