From 276fc7247fd81cb25f586e5d3970fb7affb2f748 Mon Sep 17 00:00:00 2001 From: Alexdoru <57050655+Alexdoru@users.noreply.github.com> Date: Fri, 18 Jul 2025 21:49:07 +0200 Subject: [PATCH] Cache Tessellator#instance in local var (#57) --- .../avaritia/render/CosmicItemRenderer.java | 13 ++---- .../avaritia/render/FracturedOreRenderer.java | 46 ++++--------------- 2 files changed, 11 insertions(+), 48 deletions(-) diff --git a/src/main/java/fox/spiteful/avaritia/render/CosmicItemRenderer.java b/src/main/java/fox/spiteful/avaritia/render/CosmicItemRenderer.java index 1fb1b8f..a7c2ba4 100644 --- a/src/main/java/fox/spiteful/avaritia/render/CosmicItemRenderer.java +++ b/src/main/java/fox/spiteful/avaritia/render/CosmicItemRenderer.java @@ -138,6 +138,7 @@ public class CosmicItemRenderer implements IItemRenderer { // Lumberjack.log(Level.INFO, "passes: "+passes); + final Tessellator tess = Tessellator.instance; for (int i = 0; i < passes; i++) { icon = this.getStackIcon(item, i, player); @@ -153,15 +154,7 @@ public class CosmicItemRenderer implements IItemRenderer { g = (float) (colour >> 8 & 255) / 255.0F; b = (float) (colour & 255) / 255.0F; GL11.glColor4f(r, g, b, 1.0F); - ItemRenderer.renderItemIn2D( - Tessellator.instance, - f1, - f2, - f, - f3, - icon.getIconWidth(), - icon.getIconHeight(), - scale); + ItemRenderer.renderItemIn2D(tess, f1, f2, f, f3, icon.getIconWidth(), icon.getIconHeight(), scale); } if (item.getItem() instanceof ICosmicRenderItem) { @@ -178,7 +171,7 @@ public class CosmicItemRenderer implements IItemRenderer { float minv = cosmicicon.getMinV(); float maxv = cosmicicon.getMaxV(); ItemRenderer.renderItemIn2D( - Tessellator.instance, + tess, maxu, minv, minu, diff --git a/src/main/java/fox/spiteful/avaritia/render/FracturedOreRenderer.java b/src/main/java/fox/spiteful/avaritia/render/FracturedOreRenderer.java index b9c2859..442724f 100644 --- a/src/main/java/fox/spiteful/avaritia/render/FracturedOreRenderer.java +++ b/src/main/java/fox/spiteful/avaritia/render/FracturedOreRenderer.java @@ -203,8 +203,8 @@ public class FracturedOreRenderer implements IItemRenderer { f2 = icon.getMinV(); f3 = icon.getMaxV(); - ItemRenderer - .renderItemIn2D(Tessellator.instance, f1, f2, f, f3, icon.getIconWidth(), icon.getIconHeight(), scale); + final Tessellator tess = Tessellator.instance; + ItemRenderer.renderItemIn2D(tess, f1, f2, f, f3, icon.getIconWidth(), icon.getIconHeight(), scale); boolean unknown = false; @@ -232,15 +232,8 @@ public class FracturedOreRenderer implements IItemRenderer { float maxv = oreicon.getMaxV(); GL11.glDepthFunc(GL11.GL_EQUAL); - ItemRenderer.renderItemIn2D( - Tessellator.instance, - maxu, - minv, - minu, - maxv, - icon.getIconWidth(), - icon.getIconHeight(), - scale); + ItemRenderer + .renderItemIn2D(tess, maxu, minv, minu, maxv, icon.getIconWidth(), icon.getIconHeight(), scale); GL11.glDepthFunc(GL11.GL_LEQUAL); mc.renderEngine.bindTexture(TextureMap.locationItemsTexture); @@ -261,30 +254,14 @@ public class FracturedOreRenderer implements IItemRenderer { float minv = fracicon.getMinV(); float maxv = fracicon.getMaxV(); - ItemRenderer.renderItemIn2D( - Tessellator.instance, - maxu, - minv, - minu, - maxv, - icon.getIconWidth(), - icon.getIconHeight(), - scale); + ItemRenderer.renderItemIn2D(tess, maxu, minv, minu, maxv, icon.getIconWidth(), icon.getIconHeight(), scale); GL11.glEnable(GL11.GL_ALPHA_TEST); GL11.glBlendFunc(GL11.GL_DST_COLOR, GL11.GL_ONE_MINUS_SRC_ALPHA); GL11.glColor4d(1, 1, 1, 1); mc.entityRenderer.disableLightmap(0.0); - ItemRenderer.renderItemIn2D( - Tessellator.instance, - maxu, - minv, - minu, - maxv, - icon.getIconWidth(), - icon.getIconHeight(), - scale); + ItemRenderer.renderItemIn2D(tess, maxu, minv, minu, maxv, icon.getIconWidth(), icon.getIconHeight(), scale); GL11.glDisable(GL11.GL_BLEND); @@ -301,15 +278,8 @@ public class FracturedOreRenderer implements IItemRenderer { minv = uicon.getMinV(); maxv = uicon.getMaxV(); - ItemRenderer.renderItemIn2D( - Tessellator.instance, - maxu, - minv, - minu, - maxv, - uicon.getIconWidth(), - uicon.getIconHeight(), - scale); + ItemRenderer + .renderItemIn2D(tess, maxu, minv, minu, maxv, uicon.getIconWidth(), uicon.getIconHeight(), scale); } GL11.glEnable(GL12.GL_RESCALE_NORMAL);