From f649ca53c8b01eb4a2783c45b94cb5910c23ced7 Mon Sep 17 00:00:00 2001 From: Alexdoru <57050655+Alexdoru@users.noreply.github.com> Date: Mon, 2 Nov 2026 17:35:41 +0100 Subject: [PATCH] Fix world client leak in PositionEntries$PlayerPosition (#2327) (cherry picked from commit e64a4e721481b4623f1cf1bf30e4b21d6afcddd1) --- .../angelica/debug/screen/entries/PositionEntries.java | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/main/java/com/gtnewhorizons/angelica/debug/screen/entries/PositionEntries.java b/src/main/java/com/gtnewhorizons/angelica/debug/screen/entries/PositionEntries.java index 4c92d8a8c..4680ed008 100644 --- a/src/main/java/com/gtnewhorizons/angelica/debug/screen/entries/PositionEntries.java +++ b/src/main/java/com/gtnewhorizons/angelica/debug/screen/entries/PositionEntries.java @@ -34,9 +34,6 @@ public final class PositionEntries { } } - private WorldProvider cachedProvider; - private String dimensionName = ""; - @Override public void display(DebugScreenDisplayer displayer, DebugContext context) { final EntityClientPlayerMP player = context.player(); @@ -52,10 +49,7 @@ public final class PositionEntries { facing.value(DIRECTION_NAMES[heading]).text(" (").text(TOWARDS[heading]).text(") ("); facing.value(MathHelper.wrapAngleTo180_float(player.rotationYaw), 1).text(SEPARATOR).value(MathHelper.wrapAngleTo180_float(player.rotationPitch), 1).text(')'); final WorldProvider provider = context.world().provider; - if (provider != cachedProvider) { - cachedProvider = provider; - dimensionName = provider.getDimensionName(); - } + final String dimensionName = provider.getDimensionName(); displayer.fact(DebugGroup.POSITION, "Dimension").value(dimensionName).text(" (").value(provider.dimensionId).text(')'); } }