From dfc08053d533f30dff70945bb87531d766964828 Mon Sep 17 00:00:00 2001 From: Darren Eberly Date: Mon, 13 Apr 2026 01:25:25 -0400 Subject: [PATCH] Don't advance buffer positions for Material shininess in GLSM (#1668) --- .../gtnewhorizons/angelica/glsm/states/MaterialState.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/glsm/src/main/java/com/gtnewhorizons/angelica/glsm/states/MaterialState.java b/glsm/src/main/java/com/gtnewhorizons/angelica/glsm/states/MaterialState.java index fa1af275e..1e372657a 100644 --- a/glsm/src/main/java/com/gtnewhorizons/angelica/glsm/states/MaterialState.java +++ b/glsm/src/main/java/com/gtnewhorizons/angelica/glsm/states/MaterialState.java @@ -103,9 +103,12 @@ public class MaterialState implements ISettableState { } } - public void setShininess(FloatBuffer newBuffer) { setShininess(newBuffer.get()); } + // On the buffer versions of shininess, we need to call `get(0)` explicitly specifying the index + // otherwise calling `get()` advances the buffer position, and some mods may re-use the same buffer + // in subsequent calls, resulting in a BufferUnderflowException. + public void setShininess(FloatBuffer newBuffer) { setShininess(newBuffer.get(0)); } - public void setShininess(IntBuffer newBuffer) { setShininess((float) newBuffer.get());} + public void setShininess(IntBuffer newBuffer) { setShininess((float) newBuffer.get(0)); } public void setShininess(int val) { setShininess((float) val);}