PERF: 流体图标按 16px 切块,每块一次 Tessellator 提交 #3

Closed
opened 2026-11-15 15:58:35 +00:00 by layue13 · 2 comments
Owner

调研编号:

结论(仅已处理过的单填写;待修单删掉本节)

  • 结论:待裁决(观察/建议不修)
  • 依据:全范式扫描 confirmed

现象

PositionedFluidTank 绘制循环内对每个 16px 块 startDrawingQuads/draw;纹理与颜色在循环外。

危害类与优先级

  • 危害类:PERF → 标签 type/perf
  • 优先级:p3(confirmed 观察;仅配方页少量 quad)

证据(生效源码)

  • 载体:TDLM/NEI-Integration + 分支 origin/master + pin/commit 1e88b70767d8eef8330d9f16d57ad7ca02de9505(submodule upstream)
  • 位置:src/main/java/tonius/neiintegration/PositionedFluidTank.java:96-134
  • 关键原文:
for (int i = 0; i < this.position.width; i += 16) {
    for (int j = 0; j < amount; j += 16) {
        Tessellator tessellator = Tessellator.instance;
        tessellator.startDrawingQuads();
        // ...
        tessellator.draw();
    }
}
  • applied 树路径:补丁层;该处无覆盖补丁,生效=upstream@1e88b70767d8eef8330d9f16d57ad7ca02de9505
  • 上游状态:未修

触发与复现

  • 触发条件:打开带流体槽的 NEI 配方页。
  • 静态推演:J5 逐元素提交;量级未证 ⇒ 观察不标修。
  • 未验证(仅形状相同——此时本 issue 是候选)
  • 包内相关性:模块 NEI-Integration/sides client,server/默认配置可达:是

落点

  • 主仓:TDLM/NEI-Integration → PositionedFluidTank.java:108

范式

引证

  1. 不可点开:源在 submodule upstream@1e88b70767d8eef8330d9f16d57ad7ca02de9505;mirror 可点开 —
    GuiDraw.changeTexture(TextureMap.locationBlocksTexture);
    int color = this.tank.getFluid().getFluid().getColor(this.tank.getFluid());
    GL11.glColor3ub((byte) (color >> 16 & 0xFF), (byte) (color >> 8 & 0xFF), (byte) (color & 0xFF));
    GL11.glDisable(GL11.GL_BLEND);
    int amount = Math.max(
    Math.min(
    this.position.height,
    this.tank.getFluid().amount * this.position.height / this.tank.getCapacity()),
    1);
    int posY = this.position.y + this.position.height - amount;
    for (int i = 0; i < this.position.width; i += 16) {
    for (int j = 0; j < amount; j += 16) {
    int drawWidth = Math.min(this.position.width - i, 16);
    int drawHeight = Math.min(amount - j, 16);
    int drawX = this.position.x + i;
    int drawY = posY + j;
    double minU = fluidIcon.getMinU();
    double maxU = fluidIcon.getMaxU();
    double minV = fluidIcon.getMinV();
    double maxV = fluidIcon.getMaxV();
    Tessellator tessellator = Tessellator.instance;
    tessellator.startDrawingQuads();
    tessellator
    .addVertexWithUV(drawX, drawY + drawHeight, 0, minU, minV + (maxV - minV) * drawHeight / 16F);
    tessellator.addVertexWithUV(
    drawX + drawWidth,
    drawY + drawHeight,
    0,
    minU + (maxU - minU) * drawWidth / 16F,
    minV + (maxV - minV) * drawHeight / 16F);
    tessellator.addVertexWithUV(drawX + drawWidth, drawY, 0, minU + (maxU - minU) * drawWidth / 16F, minV);
    tessellator.addVertexWithUV(drawX, drawY, 0, minU, minV);
    tessellator.draw();
    }

来源

  • 线索类型:内部代码审查(无外部报障)
  • 可解析指针:upstream@1e88b70767d8 / src/main/java/tonius/neiintegration/PositionedFluidTank.java:96-134
  • 来源标签:origin/scan
**调研编号**: ## 结论(仅已处理过的单填写;待修单删掉本节) - 结论:待裁决(观察/建议不修) - 依据:全范式扫描 confirmed ## 现象 PositionedFluidTank 绘制循环内对每个 16px 块 startDrawingQuads/draw;纹理与颜色在循环外。 ## 危害类与优先级 - 危害类:`PERF` → 标签 `type/perf` - 优先级:`p3`(confirmed 观察;仅配方页少量 quad) ## 证据(生效源码) - 载体:`TDLM/NEI-Integration` + 分支 `origin/master` + pin/commit `1e88b70767d8eef8330d9f16d57ad7ca02de9505`(submodule upstream) - 位置:`src/main/java/tonius/neiintegration/PositionedFluidTank.java:96-134` - 关键原文: ```java for (int i = 0; i < this.position.width; i += 16) { for (int j = 0; j < amount; j += 16) { Tessellator tessellator = Tessellator.instance; tessellator.startDrawingQuads(); // ... tessellator.draw(); } } ``` - applied 树路径:补丁层;该处无覆盖补丁,生效=upstream@1e88b70767d8eef8330d9f16d57ad7ca02de9505 - 上游状态:未修 ## 触发与复现 - 触发条件:打开带流体槽的 NEI 配方页。 - 静态推演:J5 逐元素提交;量级未证 ⇒ 观察不标修。 - 未验证(仅形状相同——此时本 issue 是候选) - 包内相关性:模块 `NEI-Integration`/sides `client,server`/默认配置可达:是 ## 落点 - 主仓:`TDLM/NEI-Integration` → `PositionedFluidTank.java:108` ## 范式 - 命中范式:[J5 逐元素无批提交](https://git.potatolab.uk/TDLM/mc-defect-patterns/src/commit/5c71fe760eaf11509476cc892da1e76ad0912b46/perf/J5-elementwise-submission-unbatched.md) - 扫描档 confirmed(观察,不标修)。 ## 引证 1. 不可点开:源在 submodule upstream@1e88b70767d8eef8330d9f16d57ad7ca02de9505;mirror 可点开 — https://git.nest.potatolab.uk:8443/upstream/NEI-Integration/src/commit/1e88b70767d8eef8330d9f16d57ad7ca02de9505/src/main/java/tonius/neiintegration/PositionedFluidTank.java#L96-L134 ## 来源 - 线索类型:内部代码审查(无外部报障) - 可解析指针:upstream@1e88b70767d8 / src/main/java/tonius/neiintegration/PositionedFluidTank.java:96-134 - 来源标签:origin/scan
layue13 added the
resolution
recorded
label 2026-11-15 16:41:19 +00:00
Author
Owner

同上(流体切块 Tessellator);记录关闭。

同上(流体切块 Tessellator);记录关闭。
layue13 added
resolution
fixed
and removed
resolution
recorded
labels 2026-11-15 16:46:02 +00:00
Author
Owner

观察项已修:patches/0002 PositionedFluidTank 一次 startDrawingQuads/draw 批提交所有 16px 切块。layer 6ab3821。

观察项已修:patches/0002 PositionedFluidTank 一次 startDrawingQuads/draw 批提交所有 16px 切块。layer 6ab3821。
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: TDLM/NEI-Integration#3