From bb16a0b6c057b3964fc6e5ceccda396f28d7fc39 Mon Sep 17 00:00:00 2001 From: ToobLac Date: Tue, 13 Oct 2026 20:16:03 +0800 Subject: [PATCH] =?UTF-8?q?fix(addon):=20AddonUpdatePage=20=E6=98=BE?= =?UTF-8?q?=E7=A4=BA=E6=B5=8B=E8=AF=95=E7=89=88=E6=9C=AC=E5=A4=8D=E9=80=89?= =?UTF-8?q?=E6=A1=86=E6=97=A0=E6=95=88=20(#6976)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes #6974 --- .../hmcl/ui/instances/AddonUpdatesPage.java | 23 ++++++++----------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/AddonUpdatesPage.java b/HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/AddonUpdatesPage.java index 06061ac01b..8050beed9d 100644 --- a/HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/AddonUpdatesPage.java +++ b/HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/AddonUpdatesPage.java @@ -126,18 +126,6 @@ public class AddonUpdatesPage extends BorderPane implements DecoratorPage { objects = FXCollections.observableArrayList(); - BooleanProperty showPreview = new SimpleBooleanProperty(); - { - List subscriptions = new ArrayList<>(); - FXUtils.onChangeAndOperate(showPreview, preview -> { - if (preview) objects.setAll(common.get()); - else objects.setAll(release.get()); - subscriptions.forEach(Subscription::unsubscribe); - subscriptions.clear(); - subscriptions.addAll(FXUtils.bindAllEnabled(allEnabledBox.selectedProperty(), objects.stream().map(AddonUpdateObject::enabledProperty).toArray(BooleanProperty[]::new))); - }); - } - TableView table = new TableView<>(objects); table.setEditable(true); table.getColumns().setAll(enabledColumn, fileNameColumn, currentVersionColumn, targetVersionColumn, targetVersionTypeColumn, sourceColumn, changelogColumn); @@ -150,7 +138,16 @@ public class AddonUpdatesPage extends BorderPane implements DecoratorPage { actions.setAlignment(Pos.CENTER_RIGHT); JFXCheckBox showPreviewCheck = new JFXCheckBox(i18n("addon.check_update.preview")); - showPreviewCheck.selectedProperty().bindBidirectional(showPreview); + { + List subscriptions = new ArrayList<>(); + FXUtils.onChangeAndOperate(showPreviewCheck.selectedProperty(), preview -> { + if (preview) objects.setAll(common.get()); + else objects.setAll(release.get()); + subscriptions.forEach(Subscription::unsubscribe); + subscriptions.clear(); + subscriptions.addAll(FXUtils.bindAllEnabled(allEnabledBox.selectedProperty(), objects.stream().map(AddonUpdateObject::enabledProperty).toArray(BooleanProperty[]::new))); + }); + } JFXButton exportListButton = FXUtils.newRaisedButton(i18n("button.export")); exportListButton.setOnAction(e -> exportList());