From 9dc69dbc2bfcda6ea2f367362e59d732577c2097 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=BF=AB=E4=B9=90=E5=87=A4=E7=88=AA=E7=8E=8B?= <165921128+KSSJW@users.noreply.github.com> Date: Tue, 30 Jun 2026 21:01:34 +0800 Subject: [PATCH] Refactor: Merge the duplicate logic of PriorityComparator.of(...). (#6220) --- .../java/org/jackhuang/hmcl/util/PriorityComparator.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/HMCLCore/src/main/java/org/jackhuang/hmcl/util/PriorityComparator.java b/HMCLCore/src/main/java/org/jackhuang/hmcl/util/PriorityComparator.java index d823e24cc5..6a976c1ee2 100644 --- a/HMCLCore/src/main/java/org/jackhuang/hmcl/util/PriorityComparator.java +++ b/HMCLCore/src/main/java/org/jackhuang/hmcl/util/PriorityComparator.java @@ -33,11 +33,9 @@ public final class PriorityComparator implements Comparator { /// Creates a new `PriorityComparator` with a priority map and a fallback comparator. /// Elements with a defined priority are ordered before those without. - public static > PriorityComparator of(T... values) { - Map priorities = new HashMap<>(); - for (int i = 0; i < values.length; i++) - priorities.put(values[i], i); - return new PriorityComparator<>(priorities, Comparator.naturalOrder(), true); + public static > PriorityComparator of(List values) { + Objects.requireNonNull(values); + return of(values, Comparator.naturalOrder(), true); } /// Creates a new `PriorityComparator` with a priority map, a fallback comparator, and a flag to determine the order of prioritized elements.